Skip to content

Add some code examples to the standard modules #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

FedericoPonzi
Copy link
Contributor

@FedericoPonzi FedericoPonzi commented Jan 31, 2024

Added some code examples for the standard modules. I'm planning to add examples for all of them and add the missing modules as well (see Issue #39).

Added some code examples for the standard modules
Copy link
Owner

@hwayne hwayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this! I agree that adding some examples would be helpful.

There's a couple of small rST errors in this, as well as two incorrect examples (both related to Seq(set)). Once those are fixed I'd be happy to merge!

@FedericoPonzi FedericoPonzi marked this pull request as draft January 31, 2024 22:03
@FedericoPonzi
Copy link
Contributor Author

I converted it to draft while I'm adding more code examples and modules descriptions, please let me know if you would rather merge this and have different PRs for the rest or it's fine to have single pr

@FedericoPonzi
Copy link
Contributor Author

Looking at https://github.com/tlaplus/tlaplus/tree/master/tlatools/org.lamport.tlatools/src/tla2sany/StandardModules only Randomization was missing, it should be ready to review now

@FedericoPonzi FedericoPonzi marked this pull request as ready for review January 31, 2024 23:00
@FedericoPonzi FedericoPonzi requested a review from hwayne February 1, 2024 00:24
@hwayne
Copy link
Owner

hwayne commented Feb 5, 2024

Looks a lot better! Once I download the branch and check that it builds right I think it's good to go :) (heads up might rewrite randomization to be a little less technical)

@hwayne
Copy link
Owner

hwayne commented Feb 8, 2024

Tweaked on my end, all ready to go! Thanks for writing this!

@hwayne hwayne merged commit fadb912 into hwayne:master Feb 8, 2024
@FedericoPonzi FedericoPonzi deleted the patch-1 branch February 8, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants