Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatability Patch: Only use the persistent keyring if supported by the running kernel. #119

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

landhb
Copy link
Contributor

@landhb landhb commented Feb 25, 2023

@brotskydotcom This is just for maximum compatibility for clients.

Technically the persistent keyring wasn't added until Linux kernel version 3.13, but the keyctl syscall was added in 2.6.

Even though 3.13 is fairly old now (released in 2014) it's probably worth supporting the older kernels just in case.

This isn't a breaking change so should be fine for the next patch release. If the persistent keyring exists, it will function as it has been. If it doesn't exist, there won't be a hard error for users and the key will still be stored in the Session keyring.

Copy link
Collaborator

@brotskydotcom brotskydotcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, @landhb, thanks a lot.

@brotskydotcom brotskydotcom merged commit ced3b6b into hwchen:master Feb 25, 2023
@landhb landhb deleted the fallback_persistent branch February 26, 2023 13:01
@landhb
Copy link
Contributor Author

landhb commented Feb 26, 2023

No problem! Thanks for the quick response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants