Compatability Patch: Only use the persistent keyring if supported by the running kernel. #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@brotskydotcom This is just for maximum compatibility for clients.
Technically the persistent keyring wasn't added until Linux kernel version 3.13, but the keyctl syscall was added in 2.6.
Even though 3.13 is fairly old now (released in 2014) it's probably worth supporting the older kernels just in case.
This isn't a breaking change so should be fine for the next patch release. If the persistent keyring exists, it will function as it has been. If it doesn't exist, there won't be a hard error for users and the key will still be stored in the Session keyring.