Skip to content

Commit

Permalink
Polished UserRepositoryTests.
Browse files Browse the repository at this point in the history
  • Loading branch information
@odrotbohm
odrotbohm committed Oct 12, 2011
1 parent db8aebe commit d6c4c2e
Showing 1 changed file with 73 additions and 106 deletions.
179 changes: 73 additions & 106 deletions src/test/java/org/springframework/data/jpa/repository/UserRepositoryTests.java
View file
Expand Up @@ -87,9 +87,6 @@ public void setUp() {
thirdUser.setAge(43);
}

/**
* Tests creation of users.
*/
@Test
public void testCreation() {

Expand All @@ -98,40 +95,31 @@ public void testCreation() {

flushTestUsers();

assertEquals(before + 3, countQuery.getSingleResult());
assertThat((Long) countQuery.getSingleResult(), is(before + 3));
}

/**
* Tests reading a single user.
*
* @throws Exception
*/
@Test
public void testRead() throws Exception {

flushTestUsers();

User foundPerson = repository.findOne(id);
assertEquals(firstUser.getFirstname(), foundPerson.getFirstname());
assertThat(firstUser.getFirstname(), is(foundPerson.getFirstname()));
}

/**
* Asserts, that a call to {@code UserRepository#readId(Integer)} returns {@code null} for invalid not {@code null}
* ids.
*/
@Test
public void testReadByIdReturnsNullForNotFoundEntities() {

flushTestUsers();

assertNull(repository.findOne(id * 27));
assertThat(repository.findOne(id * 27), is(nullValue()));
}

@Test
public void savesCollectionCorrectly() throws Exception {

List<User> result = repository.save(Arrays.asList(firstUser, secondUser, thirdUser));
assertNotNull(result);
assertThat(result, is(notNullValue()));
assertThat(result.size(), is(3));
assertThat(result, hasItems(firstUser, secondUser, thirdUser));
}
Expand All @@ -140,21 +128,18 @@ public void savesCollectionCorrectly() throws Exception {
public void savingNullCollectionIsNoOp() throws Exception {

List<User> result = repository.save((Collection<User>) null);
assertNotNull(result);
assertTrue(result.isEmpty());
assertThat(result, is(notNullValue()));
assertThat(result.isEmpty(), is(true));
}

@Test
public void savingEmptyCollectionIsNoOp() throws Exception {

List<User> result = repository.save(new ArrayList<User>());
assertNotNull(result);
assertTrue(result.isEmpty());
assertThat(result, is(notNullValue()));
assertThat(result.isEmpty(), is(true));
}

/**
* Tests updating a user.
*/
@Test
public void testUpdate() {

Expand All @@ -164,15 +149,15 @@ public void testUpdate() {
foundPerson.setLastname("Schlicht");

User updatedPerson = repository.findOne(id);
assertEquals(foundPerson.getFirstname(), updatedPerson.getFirstname());
assertThat(updatedPerson.getFirstname(), is(foundPerson.getFirstname()));
}

@Test
public void existReturnsWhetherAnEntityCanBeLoaded() throws Exception {

flushTestUsers();
assertTrue(repository.exists(id));
assertFalse(repository.exists(id * 27));
assertThat(repository.exists(id), is(true));
assertThat(repository.exists(id * 27), is(false));
}

@Test
Expand All @@ -181,7 +166,8 @@ public void deletesAUserById() {
flushTestUsers();

repository.delete(firstUser.getId());
assertNull(repository.findOne(firstUser.getId()));
assertThat(repository.exists(id), is(false));
assertThat(repository.findOne(id), is(nullValue()));
}

@Test
Expand All @@ -199,7 +185,7 @@ public void returnsAllSortedCorrectly() throws Exception {

flushTestUsers();
List<User> result = repository.findAll(new Sort(ASC, "lastname"));
assertNotNull(result);
assertThat(result, is(notNullValue()));
assertThat(result.size(), is(3));
assertThat(result.get(0), is(secondUser));
assertThat(result.get(1), is(firstUser));
Expand All @@ -214,6 +200,8 @@ public void deleteColletionOfEntities() {
long before = repository.count();

repository.delete(Arrays.asList(firstUser, secondUser));
assertThat(repository.exists(firstUser.getId()), is(false));
assertThat(repository.exists(secondUser.getId()), is(false));
assertThat(repository.count(), is(before - 2));
}

Expand All @@ -225,6 +213,8 @@ public void batchDeleteColletionOfEntities() {
long before = repository.count();

repository.deleteInBatch(Arrays.asList(firstUser, secondUser));
assertThat(repository.exists(firstUser.getId()), is(false));
assertThat(repository.exists(secondUser.getId()), is(false));
assertThat(repository.count(), is(before - 2));
}

Expand All @@ -240,15 +230,6 @@ public void deleteWithNullDoesNotDeleteAnything() throws Exception {
assertDeleteCallDoesNotDeleteAnything(null);
}

private void assertDeleteCallDoesNotDeleteAnything(List<User> collection) {

flushTestUsers();
long count = repository.count();

repository.delete(collection);
assertEquals(count, repository.count());
}

@Test
public void executesManipulatingQuery() throws Exception {

Expand All @@ -259,11 +240,6 @@ public void executesManipulatingQuery() throws Exception {
assertThat(repository.findByLastname("newLastname").size(), is(Long.valueOf(expected).intValue()));
}

/**
* Make sure no {@link NullPointerException} is being thrown.
*
* @see Ticket #110
*/
@Test
public void testFinderInvocationWithNullParameter() {

Expand All @@ -272,20 +248,15 @@ public void testFinderInvocationWithNullParameter() {
repository.findByLastname(null);
}

/**
* Tests, that searching by the lastname of the reference user returns exactly that instance.
*
* @throws Exception
*/
@Test
public void testFindByLastname() throws Exception {

flushTestUsers();

List<User> byName = repository.findByLastname("Gierke");

assertTrue(byName.size() == 1);
assertEquals(firstUser, byName.get(0));
assertThat(byName.size(), is(1));
assertThat(byName.get(0), is(firstUser));
}

/**
Expand All @@ -300,8 +271,8 @@ public void testFindByEmailAddress() throws Exception {

User byName = repository.findByEmailAddress("gierke@synyx.de");

assertNotNull(byName);
assertEquals(firstUser, byName);
assertThat(byName, is(notNullValue()));
assertThat(byName, is(firstUser));
}

/**
Expand All @@ -312,8 +283,8 @@ public void testReadAll() {

flushTestUsers();

List<User> reference = Arrays.asList(firstUser, secondUser);
assertTrue(repository.findAll().containsAll(reference));
assertThat(repository.count(), is(3L));
assertThat(repository.findAll(), hasItems(firstUser, secondUser, thirdUser));
}

/**
Expand Down Expand Up @@ -345,12 +316,12 @@ public void testCascadesPersisting() {

// Fetches first user from database
User firstReferenceUser = repository.findOne(firstUser.getId());
assertEquals(firstUser, firstReferenceUser);
assertThat(firstReferenceUser, is(firstUser));

// Fetch colleagues and assert link
Set<User> colleagues = firstReferenceUser.getColleagues();
assertEquals(1, colleagues.size());
assertTrue(colleagues.contains(secondUser));
assertThat(colleagues.size(), is(1));
assertThat(colleagues.contains(secondUser), is(true));
}

/**
Expand Down Expand Up @@ -379,13 +350,10 @@ public void testMergingCascadesCollegueas() {
User reference = repository.findOne(firstUser.getId());
Set<User> colleagues = reference.getColleagues();

assertNotNull(colleagues);
assertEquals(2, colleagues.size());
assertThat(colleagues, is(notNullValue()));
assertThat(colleagues.size(), is(2));
}

/**
* Tests, that the generic repository implements count correctly.
*/
@Test
public void testCountsCorrectly() {

Expand All @@ -395,22 +363,15 @@ public void testCountsCorrectly() {
user.setEmailAddress("gierke@synyx.de");
repository.save(user);

assertTrue(repository.count() == count + 1);
assertThat(repository.count() == count + 1, is(true));
}

/**
* Tests invoking a method of a custom implementation of the repository interface.
*/
@Test
public void testInvocationOfCustomImplementation() {

repository.someCustomMethod(new User());
}

/**
* Tests that overriding a finder method is recognized by the repository implementation. If an overriding method is
* found it will will be invoked instead of the automatically generated finder.
*/
@Test
public void testOverwritingFinder() {

Expand All @@ -420,14 +381,14 @@ public void testOverwritingFinder() {
@Test
public void testUsesQueryAnnotation() {

assertEquals(null, repository.findByAnnotatedQuery("gierke@synyx.de"));
assertThat(repository.findByAnnotatedQuery("gierke@synyx.de"), is(nullValue()));
}

@Test
public void testExecutionOfProjectingMethod() {

flushTestUsers();
assertEquals(1, repository.countWithFirstname("Oliver").longValue());
assertThat(repository.countWithFirstname("Oliver").longValue(), is(1L));
}

@Test
Expand Down Expand Up @@ -478,28 +439,6 @@ public void executesCombinedSpecificationsWithPageableCorrectly() {
assertThat(users.getTotalElements(), is(2L));
}

/**
* Flushes test users to the database.
*/
private void flushTestUsers() {

firstUser = repository.save(firstUser);
secondUser = repository.save(secondUser);
thirdUser = repository.save(thirdUser);

repository.flush();

id = firstUser.getId();

assertThat(id, is(notNullValue()));
assertThat(secondUser.getId(), is(notNullValue()));
assertThat(thirdUser.getId(), is(notNullValue()));

assertThat(repository.exists(id), is(true));
assertThat(repository.exists(secondUser.getId()), is(true));
assertThat(repository.exists(thirdUser.getId()), is(true));
}

@Test
public void executesMethodWithAnnotatedNamedParametersCorrectly() throws Exception {

Expand Down Expand Up @@ -582,25 +521,14 @@ public void returnsSamePageIfNoSpecGiven() throws Exception {
Pageable pageable = new PageRequest(0, 1);

flushTestUsers();
assertEquals(repository.findAll(pageable), repository.findAll(null, pageable));
assertThat(repository.findAll(null, pageable), is(repository.findAll(pageable)));
}

@Test
public void returnsAllAsPageIfNoPageableIsGiven() throws Exception {

flushTestUsers();
assertEquals(new PageImpl<User>(repository.findAll()), repository.findAll((Pageable) null));
}

private static <T> void assertSameElements(Collection<T> first, Collection<T> second) {

for (T element : first) {
assertThat(element, isIn(second));
}

for (T element : second) {
assertThat(element, isIn(first));
}
assertThat(repository.findAll((Pageable) null), is((Page<User>) new PageImpl<User>(repository.findAll())));
}

@Test
Expand Down Expand Up @@ -758,6 +686,45 @@ public void executesGreaterThatOrEqualQueriesCorrectly() {
assertThat(result, hasItems(secondUser, thirdUser));
}

private void flushTestUsers() {

firstUser = repository.save(firstUser);
secondUser = repository.save(secondUser);
thirdUser = repository.save(thirdUser);

repository.flush();

id = firstUser.getId();

assertThat(id, is(notNullValue()));
assertThat(secondUser.getId(), is(notNullValue()));
assertThat(thirdUser.getId(), is(notNullValue()));

assertThat(repository.exists(id), is(true));
assertThat(repository.exists(secondUser.getId()), is(true));
assertThat(repository.exists(thirdUser.getId()), is(true));
}

private static <T> void assertSameElements(Collection<T> first, Collection<T> second) {

for (T element : first) {
assertThat(element, isIn(second));
}

for (T element : second) {
assertThat(element, isIn(first));
}
}

private void assertDeleteCallDoesNotDeleteAnything(List<User> collection) {

flushTestUsers();
long count = repository.count();

repository.delete(collection);
assertThat(repository.count(), is(count));
}

private Page<User> executeSpecWithSort(Sort sort) {

flushTestUsers();
Expand Down

0 comments on commit d6c4c2e

Please sign in to comment.