diff --git a/Controller/ConnectController.php b/Controller/ConnectController.php index 0765cb939..8218748f1 100644 --- a/Controller/ConnectController.php +++ b/Controller/ConnectController.php @@ -56,14 +56,13 @@ final class ConnectController private RequestStack $requestStack; private EventDispatcherInterface $dispatcher; private TokenStorageInterface $tokenStorage; - private AccountConnectorInterface $accountConnector; private UserCheckerInterface $userChecker; - private RegistrationFormHandlerInterface $formHandler; private AuthorizationCheckerInterface $authorizationChecker; private FormFactoryInterface $formFactory; private Environment $twig; private RouterInterface $router; - private bool $enableConnect; + private ?AccountConnectorInterface $accountConnector; + private ?RegistrationFormHandlerInterface $formHandler; private string $grantRule; private bool $failedUseReferer; private string $failedAuthPath; @@ -80,25 +79,23 @@ public function __construct( RequestStack $requestStack, EventDispatcherInterface $dispatcher, TokenStorageInterface $tokenStorage, - AccountConnectorInterface $accountConnector, UserCheckerInterface $userChecker, - RegistrationFormHandlerInterface $formHandler, AuthorizationCheckerInterface $authorizationChecker, FormFactoryInterface $formFactory, Environment $twig, RouterInterface $router, - bool $enableConnect, string $grantRule, bool $failedUseReferer, string $failedAuthPath, bool $enableConnectConfirmation, array $firewallNames, - string $registrationForm + string $registrationForm, + ?AccountConnectorInterface $accountConnector, + ?RegistrationFormHandlerInterface $formHandler ) { $this->oauthUtils = $oauthUtils; $this->resourceOwnerMapLocator = $resourceOwnerMapLocator; $this->requestStack = $requestStack; - $this->enableConnect = $enableConnect; $this->grantRule = $grantRule; $this->failedUseReferer = $failedUseReferer; $this->failedAuthPath = $failedAuthPath; @@ -128,7 +125,7 @@ public function __construct( */ public function registrationAction(Request $request, string $key): Response { - if (!$this->enableConnect) { + if (!$this->accountConnector || !$this->formHandler) { throw new NotFoundHttpException(); } @@ -213,7 +210,7 @@ public function registrationAction(Request $request, string $key): Response */ public function connectServiceAction(Request $request, string $service): Response { - if (!$this->enableConnect) { + if (!$this->accountConnector || !$this->formHandler) { throw new NotFoundHttpException(); } diff --git a/DependencyInjection/HWIOAuthExtension.php b/DependencyInjection/HWIOAuthExtension.php index df9e95ba1..43badd5b9 100644 --- a/DependencyInjection/HWIOAuthExtension.php +++ b/DependencyInjection/HWIOAuthExtension.php @@ -95,8 +95,6 @@ public function load(array $configs, ContainerBuilder $container) } $this->createConnectIntegration($container, $config); - - $container->setAlias('hwi_oauth.user_checker', new Alias('security.user_checker', true)); } /** @@ -161,31 +159,16 @@ public function getAlias(): string */ private function createConnectIntegration(ContainerBuilder $container, array $config): void { - $container->setParameter('hwi_oauth.connect.confirmation', false); - $container->setParameter('hwi_oauth.connect.registration_form', null); - - if (!isset($config['connect'])) { - $container->setParameter('hwi_oauth.connect', false); + $container->setParameter('hwi_oauth.connect', isset($config['connect'])); + $container->setParameter('hwi_oauth.connect.confirmation', $config['connect']['confirmation'] ?? false); + $container->setParameter('hwi_oauth.connect.registration_form', $config['connect']['registration_form'] ?? null); - return; + if (isset($config['connect']['account_connector'])) { + $container->setAlias('hwi_oauth.account.connector', new Alias($config['connect']['account_connector'], true)); } - $container->setParameter('hwi_oauth.connect', true); - - foreach ($config['connect'] as $key => $serviceId) { - if ('confirmation' === $key) { - $container->setParameter('hwi_oauth.connect.confirmation', $config['connect']['confirmation']); - - continue; - } - - if ('registration_form' === $key) { - $container->setParameter('hwi_oauth.connect.registration_form', $config['connect']['registration_form']); - - continue; - } - - $container->setAlias('hwi_oauth.'.str_replace('_', '.', $key), new Alias($serviceId, true)); + if (isset($config['connect']['registration_form_handler'])) { + $container->setAlias('hwi_oauth.registration.form.handler', new Alias($config['connect']['registration_form_handler'], true)); } } } diff --git a/Resources/config/controller.xml b/Resources/config/controller.xml index 71f9d504e..da6758a29 100644 --- a/Resources/config/controller.xml +++ b/Resources/config/controller.xml @@ -5,26 +5,27 @@ xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> + + - - - %hwi_oauth.connect% %hwi_oauth.grant_rule% %hwi_oauth.failed_use_referer% %hwi_oauth.failed_auth_path% %hwi_oauth.connect.confirmation% %hwi_oauth.firewall_names% %hwi_oauth.connect.registration_form% + + diff --git a/Tests/Controller/AbstractConnectControllerTest.php b/Tests/Controller/AbstractConnectControllerTest.php index 0002ccd17..e71abcd57 100644 --- a/Tests/Controller/AbstractConnectControllerTest.php +++ b/Tests/Controller/AbstractConnectControllerTest.php @@ -1,5 +1,7 @@ createMock(RequestStack::class), $this->eventDispatcher, $this->tokenStorage, - $this->accountConnector, $this->userChecker, - $this->registrationFormHandler, $this->authorizationChecker, $this->formFactory, $this->twig, $this->router, - $connectEnabled, 'IS_AUTHENTICATED_REMEMBERED', true, 'fake_route', $confirmConnect, $firewallNames, - RegistrationFormType::class + RegistrationFormType::class, + $connectEnabled ? $this->accountConnector : null, + $connectEnabled ? $this->registrationFormHandler : null ); } } diff --git a/Tests/Controller/RedirectToServiceControllerTest.php b/Tests/Controller/RedirectToServiceControllerTest.php index acbe33d06..673a8960e 100644 --- a/Tests/Controller/RedirectToServiceControllerTest.php +++ b/Tests/Controller/RedirectToServiceControllerTest.php @@ -1,5 +1,7 @@ request->setSession($this->session); } - public function test() + public function testTargetUrlIsCorrect(): void { $controller = $this->createController(); $response = $controller->redirectToServiceAction($this->request, 'facebook'); - $this->assertEquals('https://domain.com/oauth/v2/auth', $response->getTargetUrl()); + $this->assertSame('https://domain.com/oauth/v2/auth', $response->getTargetUrl()); } public function testTargetPathParameter(): void @@ -91,7 +93,7 @@ public function testFailedUseReferer(): void ->with('_security.default.failed_target_path', 'https://google.com') ; - $controller = $this->createController(true, false); + $controller = $this->createController(true); $controller->redirectToServiceAction($this->request, 'facebook'); } diff --git a/Tests/DependencyInjection/HWIOAuthExtensionTest.php b/Tests/DependencyInjection/HWIOAuthExtensionTest.php index f1f0cb5e5..7553c5978 100644 --- a/Tests/DependencyInjection/HWIOAuthExtensionTest.php +++ b/Tests/DependencyInjection/HWIOAuthExtensionTest.php @@ -360,7 +360,6 @@ public function testConfigurationLoadDefaults(): void $this->assertParameter('hwi_oauth_connect', 'hwi_oauth.failed_auth_path'); $this->assertParameter(['any_name' => 'any_name', 'some_service' => 'some_service'], 'hwi_oauth.resource_owners'); - $this->assertParameter(false, 'hwi_oauth.connect'); $this->assertParameter(false, 'hwi_oauth.connect.confirmation'); $this->assertAlias('security.user_checker', 'hwi_oauth.user_checker'); @@ -637,9 +636,8 @@ protected function getFullConfig(): array templating_engine: "php" EOF; - $parser = new Parser(); - return $parser->parse($yaml); + return (new Parser())->parse($yaml); } private function assertAlias(string $value, string $key): void