{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":808040421,"defaultBranch":"master","name":"go","ownerLogin":"hxzhouh","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-05-30T09:06:05.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/25883521?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1717059967.910388","currentOid":""},"activityList":{"items":[{"before":"c5f2e4e56e2d3b13737de597be62f3020d59c137","after":"44ed517c42a52e0c5831383b59eae5b38428656d","ref":"refs/heads/master","pushedAt":"2024-08-06T21:40:12.000Z","pushType":"push","commitsCount":23,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/go/internal/load: make check for path in import error more robust\n\nWhen producing an ImportPathError from ImportErrorf, we check to see\nwhether the error string contains the path for the error. The issue is\nthat we were checking for the exact path string when sometimes the\nstring is quoted when the error is constructed, and the escaping in the\nquote may not match the path string. Check for both the path string, and\nthe quoted path string.\n\nFixes #68737\n\nChange-Id: I01bf4e495056e929570bc11bc1f2000ce6d2802b\nReviewed-on: https://go-review.googlesource.com/c/go/+/603475\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Sam Thanawalla ","shortMessageHtmlLink":"cmd/go/internal/load: make check for path in import error more robust"}},{"before":"34ddde165d770e0a0dbca1bd64260ed878eb48c8","after":"c5f2e4e56e2d3b13737de597be62f3020d59c137","ref":"refs/heads/master","pushedAt":"2024-08-02T16:31:27.000Z","pushType":"push","commitsCount":32,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"crypto/internal/cryptotest: add tests for the cipher.Stream interface\n\nThis CL creates tests for the cipher.Stream interface in the new\ncryptotest package. This set of tests is called from the tests of\nimplementations of the Stream interface e.g. ctr_test.go, ofb_test.go,\nrc4_test.go, etc.\n\nUpdates #25309\n\nChange-Id: I57204ef9f4c0ec09b94e88466deb03c6715e411d\nReviewed-on: https://go-review.googlesource.com/c/go/+/595564\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Michael Knyszek \nAuto-Submit: Filippo Valsorda \nReviewed-by: Filippo Valsorda \nReviewed-by: Russell Webb ","shortMessageHtmlLink":"crypto/internal/cryptotest: add tests for the cipher.Stream interface"}},{"before":"86bec1ec198f2720c83bd232a72b800b4ea5a9f6","after":"34ddde165d770e0a0dbca1bd64260ed878eb48c8","ref":"refs/heads/master","pushedAt":"2024-07-31T19:36:52.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/go: fix windows test failure for test_buildinfo_godebug_issue68053\n\nFix required adding $GOEXE because windows will produce a .exe file.\n\nFixes: #68673\n\nCq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest,gotip-windows-amd64-longtest\nChange-Id: I25206de362ee4be6a9c54bd1baa405f325d79313\nReviewed-on: https://go-review.googlesource.com/c/go/+/602095\nReviewed-by: Michael Matloob \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/go: fix windows test failure for test_buildinfo_godebug_issue68053"}},{"before":"fac95803ebe49b95fe93f9f8034bace69cb60119","after":"86bec1ec198f2720c83bd232a72b800b4ea5a9f6","ref":"refs/heads/master","pushedAt":"2024-07-31T04:34:15.000Z","pushType":"push","commitsCount":59,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"go/types: record pointer and parentheses in receiver expressions\n\nCL 594740 rewrote type checking of method receiver types. Because that\nCL takes apart receivers \"manually\" rather than using the regular code\nfor type checking type expressions, pointer and parenthesized receiver\ntype expressions were not recorded anymore.\n\nAdjust the code that typechecks method receivers to a) use ordinary\ntype expression checking for non-generic receivers, and b) to record\na missing pointer and any intermediate parenthesized expressions in\ncase of a generic receiver.\n\nAdd many extra tests verifying that the correct types for parenthesized\nand pointer type expressions are recorded in various source positions.\n\nNote that the parser used by the compiler and types2 doesn't encode\nunnecessary parentheses in type expressions in its syntax tree.\nAs a result, the tests that explicitly test parentheses don't work\nin types2 and are commented out.\n\nThis CL adds code (disabled by default) to the parser to encode\nparentheses in type expressions in the syntax tree. When enabled,\nthe commented out types2 tests pass like in go/types.\n\nFixes #68639.\nFor #51343.\n\nChange-Id: Icf3d6c76f7540ee53e229660be8d78bb25380539\nReviewed-on: https://go-review.googlesource.com/c/go/+/601657\nReviewed-by: Tim King \nReviewed-by: Robert Griesemer \nAuto-Submit: Robert Griesemer \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/types: record pointer and parentheses in receiver expressions"}},{"before":"c7ea20195a3415668047eebdc488a4af1f629f04","after":"fac95803ebe49b95fe93f9f8034bace69cb60119","ref":"refs/heads/master","pushedAt":"2024-07-26T21:52:51.000Z","pushType":"push","commitsCount":21,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"runtime: remove darwin-amd64-10_14 builder check\n\nBy now macOS 11 is the minimum required version.\n\nUpdates #43926\n\nChange-Id: I13716e2e521c26bd9997f0ea1b717cf72ab7e47c\nReviewed-on: https://go-review.googlesource.com/c/go/+/601276\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cherry Mui \nAuto-Submit: Cuong Manh Le \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"runtime: remove darwin-amd64-10_14 builder check"}},{"before":"fe87b586c036ae7ad25e22896cb90f95421545fe","after":"c7ea20195a3415668047eebdc488a4af1f629f04","ref":"refs/heads/master","pushedAt":"2024-07-24T17:01:11.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/compile: fix typo in comment\n\nChange-Id: Ied098312399d2d6557ebf0ee294ca0e71dfa677b\nGitHub-Last-Rev: 82f914e85756728976646b490223352059c1953a\nGitHub-Pull-Request: golang/go#68565\nReviewed-on: https://go-review.googlesource.com/c/go/+/600655\nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"cmd/compile: fix typo in comment"}},{"before":"3959d54c0bd5c92fe0a5e33fedb0595723efc23b","after":"fe87b586c036ae7ad25e22896cb90f95421545fe","ref":"refs/heads/master","pushedAt":"2024-07-23T18:46:22.000Z","pushType":"push","commitsCount":21,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"runtime: remove VZEROUPPER in asyncPreempt on darwin/amd64\n\nUpdates #37174\nUpdates #49233\nFixes #41152\n\nChange-Id: I35b148c8bc132f02dd6a5a6bb48b711fb5c5df9e\nReviewed-on: https://go-review.googlesource.com/c/go/+/560955\nReviewed-by: Keith Randall \nAuto-Submit: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"runtime: remove VZEROUPPER in asyncPreempt on darwin/amd64"}},{"before":"70491a81113e7003e314451f3e3cf134c4d41dd7","after":"3959d54c0bd5c92fe0a5e33fedb0595723efc23b","ref":"refs/heads/master","pushedAt":"2024-07-20T11:17:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"runtime: mark lockWithRankMayAcquire as nosplit\n\nThe function is called in nosplit context already.\n\nFixes #68525\n\nChange-Id: I8b9e324335b7c605d5a20cacdd58df09b7a7cf52\nReviewed-on: https://go-review.googlesource.com/c/go/+/599675\nReviewed-by: Cherry Mui \nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Cuong Manh Le ","shortMessageHtmlLink":"runtime: mark lockWithRankMayAcquire as nosplit"}},{"before":"071b8d51c1a70fa6b12f0bed2e93370e193333fd","after":"70491a81113e7003e314451f3e3cf134c4d41dd7","ref":"refs/heads/master","pushedAt":"2024-07-19T05:02:29.000Z","pushType":"push","commitsCount":24,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"maps: document handling of non-reflexive keys\n\nFixes #63312\n\nChange-Id: I7861bddcd4c6dc208b4449b923eb2785a122aadf\nReviewed-on: https://go-review.googlesource.com/c/go/+/553157\nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor \nReviewed-by: Keith Randall \nReviewed-by: qiu laidongfeng2 <2645477756@qq.com>\nAuto-Submit: Keith Randall ","shortMessageHtmlLink":"maps: document handling of non-reflexive keys"}},{"before":"b3040679ad0eccaaadb825ed8c0704086ecc23eb","after":"071b8d51c1a70fa6b12f0bed2e93370e193333fd","ref":"refs/heads/master","pushedAt":"2024-07-13T23:32:40.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd: vendor golang.org/x/telemetry@268b4a8ec2d7\n\nCommands run, from cmd:\n go get golang.org/x/telemetry@268b4a8ec2d7\n go mod tidy\n go mod vendor\n\nCommands run, from std (to keep versions consistent):\n go get golang.org/x/sys@v0.22.0\n go mod tidy\n go mod vendor\n\nFixes #67617\n\nChange-Id: I65e759c9b03443619a2a7acbeba53694ff5bbf6a\nReviewed-on: https://go-review.googlesource.com/c/go/+/597896\nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Robert Findley \nReviewed-by: Dmitri Shuralyov \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd: vendor golang.org/x/telemetry@268b4a8ec2d7"}},{"before":"87ec2c959c73e62bfae230ef7efca11ec2a90804","after":"b3040679ad0eccaaadb825ed8c0704086ecc23eb","ref":"refs/heads/master","pushedAt":"2024-07-10T11:08:34.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"math: remove riscv64 assembly implementations of rounding\n\nFixes #68322\n\nThis reverts commit ad377e906a8ee6f27545d83de280206dacec1e58.\n\nChange-Id: Ifa4811e2c679d789cc830dbff5e50301410e24d0\nReviewed-on: https://go-review.googlesource.com/c/go/+/596516\nReviewed-by: Than McIntosh \nReviewed-by: Keith Randall \nCommit-Queue: Cuong Manh Le \nAuto-Submit: Cuong Manh Le \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cuong Manh Le ","shortMessageHtmlLink":"math: remove riscv64 assembly implementations of rounding"}},{"before":"ad77cefeb2f5b3f1cef4383e974195ffc8610236","after":"87ec2c959c73e62bfae230ef7efca11ec2a90804","ref":"refs/heads/master","pushedAt":"2024-07-09T10:58:10.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"testing: remove call to os.Exit in documentation for TestMain\n\nIn the example for the TestMain function, os.Exit was called explicitly,\nwhich is no longer necessary since Go 1.15 (see change #219639).\n\nUpdates #34129\n\nChange-Id: Ia8021de0d5699742adbb7ab6d28b11c841e596dc\nReviewed-on: https://go-review.googlesource.com/c/go/+/596977\nReviewed-by: Ian Lance Taylor \nReviewed-by: Damien Neil \nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"testing: remove call to os.Exit in documentation for TestMain"}},{"before":"71f9dbb1e409a28680f40c60fad5a386ed92a096","after":"ad77cefeb2f5b3f1cef4383e974195ffc8610236","ref":"refs/heads/master","pushedAt":"2024-07-06T09:25:45.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/compile: correct RewriteMultiValueCall fatal message\n\nThe function name was changed in CL 331470.\n\nChange-Id: I6f41866a9c5ccce594dd84185ebfc1c5af280184\nReviewed-on: https://go-review.googlesource.com/c/go/+/596395\nReviewed-by: Cherry Mui \nAuto-Submit: Cuong Manh Le \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/compile: correct RewriteMultiValueCall fatal message"}},{"before":"148755a27b50134d1db72c3c0bdf500815569531","after":"71f9dbb1e409a28680f40c60fad5a386ed92a096","ref":"refs/heads/master","pushedAt":"2024-07-03T13:43:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/compile: emit error message on mismatch import path\n\nFixes #54542\n\nChange-Id: I16cfb84fc54892923106d0a6f0b3ba810886d077\nReviewed-on: https://go-review.googlesource.com/c/go/+/596396\nAuto-Submit: Cuong Manh Le \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/compile: emit error message on mismatch import path"}},{"before":"94982a07825aec711f11c97283e99e467838d616","after":"148755a27b50134d1db72c3c0bdf500815569531","ref":"refs/heads/master","pushedAt":"2024-07-03T03:40:17.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/link: document -checklinkname option\n\nFor #67401\n\nChange-Id: I04bff1c942a4033325450c0b7dddc7980f3373cc\nReviewed-on: https://go-review.googlesource.com/c/go/+/596216\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/link: document -checklinkname option"}},{"before":"d3c93f2f00fe40eb6f8b0bf9c81b15ddd9872119","after":"94982a07825aec711f11c97283e99e467838d616","ref":"refs/heads/master","pushedAt":"2024-07-02T10:27:00.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/go/internal/workcmd: remove a potentially confusing statement\n\nA statement in the go work use docs that was meant to clarify that go\nwork use would clean up use statements where the directories did not\nexist ended up causing confusion.\n\nRemove that statement for now. We might want to add something back in\nthe future.\n\nFor #68245\n\nChange-Id: I7f6646b5dd05c18aa15e0e54f2816753f318404e\nReviewed-on: https://go-review.googlesource.com/c/go/+/595536\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Eli Bendersky ","shortMessageHtmlLink":"cmd/go/internal/workcmd: remove a potentially confusing statement"}},{"before":"82c371a307116450e9ab4dbce1853da3e69f4061","after":"d3c93f2f00fe40eb6f8b0bf9c81b15ddd9872119","ref":"refs/heads/master","pushedAt":"2024-07-01T19:13:45.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/go: update go clean help message\n\nUpdate the help message for the go clean command to include\nthe correct usage and flags for better clarity.\n\nThis change follows instructions by Ian on this thread .\n\nChange-Id: Ia509a38ee9ec7c31d384c3563535c5e3ccd9a9ce\nGitHub-Last-Rev: 3048b2e4bd10a8d25da479f96c9d90ecb3c63082\nGitHub-Pull-Request: golang/go#68135\nReviewed-on: https://go-review.googlesource.com/c/go/+/593639\nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Michael Matloob \nCommit-Queue: Ian Lance Taylor \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/go: update go clean help message"}},{"before":"ea537cca314d9da5365eeefcc375410c76e93b36","after":"82c371a307116450e9ab4dbce1853da3e69f4061","ref":"refs/heads/master","pushedAt":"2024-06-29T04:58:43.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/compile: drop internal range-over-func vars from DWARF output\n\nDrops internal range-over-func variables from the DWARF output\n(excluding #yield which is used by Delve).\n\nFixes #68238\n\nChange-Id: Ic035e37ca3560347276cdc3b469fd564da33f4f5\nReviewed-on: https://go-review.googlesource.com/c/go/+/594257\nReviewed-by: Than McIntosh \nReviewed-by: Cherry Mui \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: David Chase \nReviewed-by: Hyang-Ah Hana Kim \nAuto-Submit: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"cmd/compile: drop internal range-over-func vars from DWARF output"}},{"before":"5a18e79687dea15680ff5f799b549fa0efd0cad9","after":"ea537cca314d9da5365eeefcc375410c76e93b36","ref":"refs/heads/master","pushedAt":"2024-06-28T10:07:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/go/internal/help: add documentation for language version downgrading\n\nThis change adds documentation for language version downgrading using\nbuild constraints.\n\nFixes #68161\nFor #61894\n\nChange-Id: I283a51afd7020c9fd1f5469a6a93fd814ba32f7e\nReviewed-on: https://go-review.googlesource.com/c/go/+/595475\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/go/internal/help: add documentation for language version downgrading"}},{"before":"44f18706661db8b865719d15a5cfa0515d1a4fca","after":"5a18e79687dea15680ff5f799b549fa0efd0cad9","ref":"refs/heads/master","pushedAt":"2024-06-26T22:17:56.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/link: don't skip code sign even if dsymutil didn't generate a file\n\nEven if dsymutil didn't generate a file (which should not happen\nwith the Apple toolchain with the correct setup), we should not\nskip next steps, e.g. code sign. A return statement makes it exit\ntoo early.\n\nUpdates #68088.\n\nChange-Id: Ic1271ed1b7fe5bdee5a25cc5d669a105173b389e\nReviewed-on: https://go-review.googlesource.com/c/go/+/593660\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/link: don't skip code sign even if dsymutil didn't generate a file"}},{"before":"4f77a83589baa5a3038cc6e35615084dc7e5f0c1","after":"44f18706661db8b865719d15a5cfa0515d1a4fca","ref":"refs/heads/master","pushedAt":"2024-06-22T00:56:23.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/link: handle dynamic import variables on Darwin in plugin mode\n\nCL 501855 added support for cgo_dynamic_import variables on Darwin.\nBut it didn't support the plugin build mode on amd64, where the\nassembler turns a direct load (R_PCREL) to a load via GOT\n(R_GOTPCREL). This CL adds the support. We just need to handle\nexternal linking mode, as this can only occur in plugin or shared\nbuild mode, which requires external linking.\n\nFixes #67976.\nUpdates #50891.\n\nChange-Id: I0f56265d50bfcb36047fa5538ad7a5ec77e7ef96\nReviewed-on: https://go-review.googlesource.com/c/go/+/592499\nReviewed-by: David Chase \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/link: handle dynamic import variables on Darwin in plugin mode"}},{"before":"8f5c6904b616fd97dde4a0ba2f5c71114e588afd","after":"4f77a83589baa5a3038cc6e35615084dc7e5f0c1","ref":"refs/heads/master","pushedAt":"2024-06-19T22:00:01.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"internal/syscall/unix: fix UTIME_OMIT for dragonfly\n\nCL 219638 added UTIME_OMIT values for various systems. The value for\nDragonFly BSD appears to be incorrect.\n\nThe correct value is -2 (see references below), while -1 is used for\nUTIME_NOW. As a result, timestamp is changed to the current time instead\nof not touching. This should have been caught by the accompanying test\ncase, TestChtimesWithZeroTimes, but its failures are essentially skipped\non dragonfly (this is being fixed separately in a followup CL 591535).\n\nImprove formatting while at it.\n\nReferences:\n - https://github.com/DragonFlyBSD/DragonFlyBSD/blob/965b380e9609/sys/sys/stat.h#L284\n - https://go.googlesource.com/sys/+/refs/tags/v0.20.0/unix/zerrors_dragonfly_amd64.go#1421\n\nChange-Id: I432360ca982c84b7cd70d0cf01d860af9ff985fa\nReviewed-on: https://go-review.googlesource.com/c/go/+/589496\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Cherry Mui \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nCommit-Queue: Ian Lance Taylor ","shortMessageHtmlLink":"internal/syscall/unix: fix UTIME_OMIT for dragonfly"}},{"before":"ca5ba146da7a9d4e2a8cbe1715a78be42b45a745","after":"8f5c6904b616fd97dde4a0ba2f5c71114e588afd","ref":"refs/heads/master","pushedAt":"2024-06-17T11:27:51.000Z","pushType":"push","commitsCount":16,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"syscall: selectively update zerrors_* on openbsd/386, openbsd/arm and openbsd/amd64\n\nThe EBADMSG, ENOTRECOVERABLE, EOWNERDEAD and EPROTO Errno are missing\non openbsd/386, openbsd/arm and openbsd/amd64. These are the earliest\nOpenBSD ports and they did not exist in the system headers when the\nrelevant zerror_* file was generated.\n\nThese exist for all other ports, hence it makes sense to add them\nfor consistency. Update error and signal strings so that they are\nalso consistent across OpenBSD ports.\n\nFixes #67998\n\nChange-Id: I948857ef5bddcfbcdfb102c95e571d9cee009e77\nReviewed-on: https://go-review.googlesource.com/c/go/+/592795\nReviewed-by: Mauri de Souza Meneguzzo \nAuto-Submit: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI \nCommit-Queue: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nReviewed-by: Cherry Mui ","shortMessageHtmlLink":"syscall: selectively update zerrors_* on openbsd/386, openbsd/arm and…"}},{"before":"c83b1a7013784098c2061ae7be832b2ab7241424","after":"ca5ba146da7a9d4e2a8cbe1715a78be42b45a745","ref":"refs/heads/master","pushedAt":"2024-06-13T04:20:47.000Z","pushType":"push","commitsCount":23,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/compile/internal: add a PGO devirt post-lookup cleanup hook\n\nThe PGO-based devirtualization helper pgoir.addIndirectEdges makes a\nseries of calls into the unified IR reader to import functions that\nwould not normally be imported but may be the target of a hot indirect\ncall from the current package. This importing primarily targets at\nnon-generic functions and methods, but as part of the process we can\nencounter types that have methods (including generic methods) whose\nbodies need to be read in. When the reader encounters an inlinable\nfunc of this sort, it may (depending on the context) decide not to\nread the body right away, but instead adds the func to a list\n(\"todoBodies\") to be read in later on in a more convenient context.\n\nIn the bug in question, a hot method lookup takes place in\npgoir.addIndirectEdges, and as part of the import process we wind up\nwith a type T with method M that is in this partially created state,\nand in addition T gets added to the unified IR's list of types that\nmay need method wrappers. During wrapper generation we create a new\nwrapper \"(*T).M\" whose body has a call to \"T.M\", then farther on down\nthe pike during escape analysis we try to analyze the two functions;\nthis causes a crash due to \"T.M\" being in partially constructed state.\n\nAs a fix, add a new \"PostLookupCleanup\" hook (in the unified IR\nreader) that pgoir.addIndirectEdges can invoke that takes care of\nreading in the bodies of any functions that have been added to the\n\"todoBodies\" list.\n\n[Note: creating a test case for this problem is proving to be very\ntricky; a new test will be added in a subsequent patch].\n\nFixes #67746.\n\nChange-Id: Ibc47ee79e08a55421728d35341df80a865231cff\nReviewed-on: https://go-review.googlesource.com/c/go/+/591075\nReviewed-by: Cherry Mui \nReviewed-by: Cuong Manh Le \nReviewed-by: Michael Pratt \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"cmd/compile/internal: add a PGO devirt post-lookup cleanup hook"}},{"before":"0b72631a8229bcb86913f4855e217ddedbfbbb46","after":"c83b1a7013784098c2061ae7be832b2ab7241424","ref":"refs/heads/master","pushedAt":"2024-06-10T02:54:46.000Z","pushType":"push","commitsCount":11,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"sync: include links to the Go memory model in package documentation\n\nThe lack of links to https://go.dev/ref/mem in the sync package\ndocumentation makes it difficult to read for people who have no previous\nknowledge of that page. This PR includes the links where needed.\n\nFixes #67891\n\nChange-Id: I0e1344cc6d7b702f4cb2e55fe0fcee3eb089391a\nGitHub-Last-Rev: 427cf58aaeaae2e4b060248dd592e5fe8c6b7df4\nGitHub-Pull-Request: golang/go#67892\nReviewed-on: https://go-review.googlesource.com/c/go/+/591395\nReviewed-by: Michael Knyszek \nAuto-Submit: Ian Lance Taylor \nReviewed-by: Ian Lance Taylor \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"sync: include links to the Go memory model in package documentation"}},{"before":"f7c330eac7777612574d8a1652fd415391f6095e","after":"0b72631a8229bcb86913f4855e217ddedbfbbb46","ref":"refs/heads/master","pushedAt":"2024-06-07T17:39:38.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"cmd/compile: generate args_stackmap for ABI0 assembly func regardless of linkname\n\nCurrently, the compiler generates the argument stack map based on\nthe function signature for bodyless function declarations, if it\nis not linknamed. The assumption is that linknamed function is\nprovided by (Go code in) another package, so its args stack map\nwill be generated when compiling that package.\n\nNow we have linknames added to declarations of assembly functions,\nto signal that this function is accessed externally. Examples\ninclude runtime.morestack_noctxt, math/big.addVV. In the current\nimplementation the compiler does not generate its args stack map.\nThat causes the assembly function's args stack map missing.\nInstead, change it to generate the stack map if it is a\ndeclaration of an ABI0 function, which can only be defined in\nassembly and passed to the compiler through the -symabis flag. The\nstack map generation currently only works with ABI0 layout anyway,\nso we don't need to handle ABIInternal assembly functions.\n\nChange-Id: Ic9da3b4854c604e64ed01584da3865994f5b95b8\nReviewed-on: https://go-review.googlesource.com/c/go/+/587928\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh ","shortMessageHtmlLink":"cmd/compile: generate args_stackmap for ABI0 assembly func regardless…"}},{"before":"cf501e05e138e6911f759a5db786e90b295499b9","after":"f7c330eac7777612574d8a1652fd415391f6095e","ref":"refs/heads/master","pushedAt":"2024-06-07T07:21:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"runtime: add a note on SetFinalizer doc about method receiver\n\nA method receiver can be collected during the execution of that method.\nThis does make sense when thinking about how the GC would work, but\nalso seems not very obvious, so a point in the docs can increase the\nchance of avoiding issues caused by missing KeepAlive of method\nreceivers.\n\nChange-Id: I6817237dd022b5729dbdcda1b9f70c7059605575\nGitHub-Last-Rev: 878bf3fde7b4ed66be0302ffdd5e704b4cd70a6c\nGitHub-Pull-Request: golang/go#67777\nReviewed-on: https://go-review.googlesource.com/c/go/+/589735\nAuto-Submit: Ian Lance Taylor \nReviewed-by: Keith Randall \nReviewed-by: Keith Randall \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Ian Lance Taylor ","shortMessageHtmlLink":"runtime: add a note on SetFinalizer doc about method receiver"}},{"before":"45967bb18e04fa6dc62c2786c87ce120443c64f6","after":"cf501e05e138e6911f759a5db786e90b295499b9","ref":"refs/heads/master","pushedAt":"2024-06-06T22:03:01.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"net/http: send body or close connection on expect-100-continue requests\n\nWhen sending a request with an \"Expect: 100-continue\" header,\nwe must send the request body before sending any further requests\non the connection.\n\nWhen receiving a non-1xx response to an \"Expect: 100-continue\" request,\nsend the request body if the connection isn't being closed after\nprocessing the response. In other words, if either the request\nor response contains a \"Connection: close\" header, then skip sending\nthe request body (because the connection will not be used for\nfurther requests), but otherwise send it.\n\nCorrect a comment on the server-side Expect: 100-continue handling\nthat implied sending the request body is optional. It isn't.\n\nFor #67555\n\nChange-Id: Ia2f12091bee697771087f32ac347509ec5922d54\nReviewed-on: https://go-review.googlesource.com/c/go/+/591255\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Jonathan Amsterdam ","shortMessageHtmlLink":"net/http: send body or close connection on expect-100-continue requests"}},{"before":"7274921681d1ddf4d3246b0c92f0d6d6580afc7a","after":"45967bb18e04fa6dc62c2786c87ce120443c64f6","ref":"refs/heads/master","pushedAt":"2024-06-06T04:33:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"runtime: soften up the GCTestIsReachable test a bit\n\nThis test can fail due to objects being incorrectly retained due\nto conservative scanning. Allow a bit of slop (1 accidentally\nretained object) to prevent flaky failures.\n\nFixes #67204\n\n\"fixes\" is a bit too strong a word. More like, hopefully reduces\nthe false positive rate to something approaching 0.\n\nChange-Id: I09984f0cce50d8209aef19f3d89b0e295c86f8d1\nReviewed-on: https://go-review.googlesource.com/c/go/+/590615\nReviewed-by: Keith Randall \nReviewed-by: Michael Knyszek \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"runtime: soften up the GCTestIsReachable test a bit"}},{"before":"1b07b774c06ba0a0baf0a19324ab76ace5741305","after":"7274921681d1ddf4d3246b0c92f0d6d6580afc7a","ref":"refs/heads/master","pushedAt":"2024-06-05T23:42:25.000Z","pushType":"push","commitsCount":7,"pusher":{"login":"pull[bot]","name":null,"path":"/apps/pull","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/12910?s=80&v=4"},"commit":{"message":"doc: document new default for GODEBUG gotypesalias setting in release notes\n\nFor #65614.\n\nChange-Id: I9487521817348053170da293c01ac55f6e3dcd20\nReviewed-on: https://go-review.googlesource.com/c/go/+/590895\nReviewed-by: Dmitri Shuralyov \nReviewed-by: Robert Griesemer \nAuto-Submit: Robert Griesemer \nTryBot-Bypass: Robert Griesemer \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"doc: document new default for GODEBUG gotypesalias setting in release…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEk42UdAA","startCursor":null,"endCursor":null}},"title":"Activity · hxzhouh/go"}