Make Hybrid_Endpoint methods non-static #396

Closed
nazar-pc opened this Issue Feb 17, 2015 · 2 comments

Projects

None yet

2 participants

@nazar-pc
Contributor

I'm currently experimenting with ReactPHP and since this class may store state in its static properties this will definitely cause problems in asynchronous long-playing environment.
If there is no need to call statically anything except ::process() from outside (it is so at the first glance) we can create object in ::process() method and pass argument there. This will allow to convert all other methods into non-static calls while keeping previous interface.
If you thing this is OK - I can send pull request for this change.

@StorytellerCZ
Contributor

Definitely send a PR. It is easier to talk about it when we see exactly the changes you are suggesting.

@nazar-pc
Contributor
nazar-pc commented Mar 4, 2015

PR #408

@StorytellerCZ StorytellerCZ added this to the 2.x milestone Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment