Dropbox OAuth2 provider, close #344 #367

Merged
merged 4 commits into from Jan 3, 2015

Projects

None yet

3 participants

@VladyslavKurmaz
Contributor

No description provided.

@StorytellerCZ
Contributor

#344
Please move the provider into additional-providers and remove the config.php inserts, then I'll be happy to merge.

@StorytellerCZ StorytellerCZ added this to the 2.x milestone Dec 29, 2014
@VladyslavKurmaz
Contributor

Ok. I will do it.

@StorytellerCZ
Contributor

Thanks!

@VladyslavKurmaz
Contributor

I just moved Dropbox provider to the right folder

@hakre
hakre commented Dec 31, 2014

http://hybridauth.sourceforge.net/userguide/IDProvider_info_Dropbox.html gives a 404.

And your Pull request can benefit from making it a single commit by sqaushing all those four commits into one. http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

And instead of merging the remote master, rebase your development changes on top of it.

Hope this helps a little.

@VladyslavKurmaz
Contributor

And your Pull request can benefit from making it a single commit by sqaushing all those four commits >into one.

Thanks. I will add rebase step before further pull requests

IDProvider_info_Dropbox.html gives a 404.

Could you please advice, how can I create this page and add to the http://hybridauth.sourceforge.net/userguide

I checked svn access to the sourceforge hosted projects
http://sourceforge.net/p/forge/documentation/svn/
but with no luck.

@StorytellerCZ StorytellerCZ self-assigned this Jan 3, 2015
@StorytellerCZ
Contributor

@VladyslavKurmaz I'm currently working on updating the sourceforge webpage. After I'm done with that I expect that it will be posted to its own repository or branch here on Github prior to release of v2.4

I will update more on it in #369

@StorytellerCZ StorytellerCZ merged commit de55b32 into hybridauth:master Jan 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment