add access token to header in google provider #406

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@Remo
Contributor
Remo commented Mar 2, 2015
  • Replaces #390
  • This should make it possible to call google POST methods
  • We still have to undo this change #296 as explained here #389 (comment)
@Remo Remo referenced this pull request Mar 2, 2015
Closed

send authentication header #390

@StorytellerCZ StorytellerCZ added this to the 2.x milestone Mar 3, 2015
@StorytellerCZ
Contributor

Could you undo #296 here so it is all in one place? Thank you! Also a changelog message would be appreciated, but I can take care of that. ;)

@Remo
Contributor
Remo commented Mar 4, 2015

I thought about that, but it's not that easy. If I undo that change, we'll break sites that depend on that code. Once we undo it, everyone who depends on it will have to build the query string before calling hybridauth.. Adding an option to disable the auto query string building is ugly too, but it wouldn't be a breaking change.. Any ideas?

@StorytellerCZ
Contributor

#296 was changed on January 3rd, so it is part of 2.4 version and not the current 2.3 hence only people who keep up with the development branch depend on it.

@Remo
Contributor
Remo commented Mar 18, 2015

Okay I see.. This OAuth stuff is confusing me more and more, now I have to use Authorization..

@StorytellerCZ
Contributor

@Remo So it should be:

$this->api->curl_header = array("Authorization: OAuth " . $this->access_token);

???

@StorytellerCZ StorytellerCZ removed the 2.x label Mar 26, 2015
@StorytellerCZ StorytellerCZ added a commit that closed this pull request Mar 26, 2015
@StorytellerCZ StorytellerCZ Close #406 351223c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment