Fix warnings for getUserByResponse() in Vkontakt provider. #559

Merged
merged 1 commit into from Oct 12, 2015

Projects

None yet

3 participants

@sumthief
sumthief commented Oct 5, 2015

This method doesn't consider that user can have empty fields as 'country' and 'city'. So there are will be two warnings.

@sumthief sumthief changed the title from Fix warnings for getUserByResponse(). to Fix warnings for getUserByResponse() in Vkontakt provider. Oct 6, 2015
@StorytellerCZ
Contributor

Thanks!

@StorytellerCZ StorytellerCZ merged commit f2623a9 into hybridauth:master Oct 12, 2015

1 check passed

Scrutinizer 2 new issues, 1 updated code elements
Details
@StorytellerCZ StorytellerCZ added this to the 2.x milestone Oct 12, 2015
@merkuriy

In my opinion there is something wrong is_string($city) and property_exists($city, 'name').
Perhaps it would be better just like so #565

@StorytellerCZ
Contributor

@merkuriy Feel free to submit a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment