Fixed Google now enforcing application/x-www-form-urlencoded content #707

Merged
merged 1 commit into from Dec 9, 2016

Projects

None yet

8 participants

@chdeliens
Contributor

This OAuth2Client class is now compliant with the RFC6749 specifications (https://tools.ietf.org/html/rfc6749#section-2.3.1) regarding POST requests.

@chdeliens chdeliens Fixed Google now enforcing application/x-www-form-urlencoded content
This OAuth2Client class is now compliant with the RFC6749 specifications (https://tools.ietf.org/html/rfc6749#section-2.3.1) regarding POST requests.
acf29f9
@chdeliens
Contributor
@davidmars

thx

@StorytellerCZ StorytellerCZ added this to the 2.x milestone Dec 9, 2016
@neo22s
Contributor
neo22s commented Dec 9, 2016

thanks!! this fixes #694

@forevermatt
Contributor

We're hitting this problem, too. Thank you @chdeliens and Adzzz for figuring this out. @StorytellerCZ, is there anything we can do to help get this tested/released?

@StorytellerCZ
Contributor

@forevermatt I will release this in a patch within an ASAP.

@StorytellerCZ StorytellerCZ merged commit 84e25b5 into hybridauth:master Dec 9, 2016
@chrishadi

@chdeliens after update to this version, I cant login with Facebook. The error message is
Undefined property: Hybrid_User_Profile::$username
When we try to add $username in User_Profile and it works.

Can you check it?
Thank you.

@neo22s
Contributor
neo22s commented Dec 13, 2016

I have just tested at https://yclas.com/panel/auth/login where we use hybridauth and not any issue.

@chrishadi

@neo22s I'm sorry it's my bad. It turns out my code which access the $username property of an User_Profileobject that cause the error.

@ApacheEx ApacheEx referenced this pull request Jan 4, 2017
Closed

Google login problem #719

@ao
ao commented Jan 12, 2017

Thanks, this was driving me crazy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment