Skip to content

Switch from Net::HTTP to Net::HTTP::Persistent for improved performance #6

Open
wants to merge 1 commit into from

3 participants

@justindossey

Example use:
ga = Gabba::Gabba.new('UA-12345', 'www.example.com')
events.each {|category, action, label, value| ga.event(category, action, label, value)}

@justindossey justindossey Added use of Net::HTTP::Persistent for requests.
Example use:
ga = Gabba::Gabba.new('UA-12345', 'www.example.com')
events.each {|category, action, label, value| ga.event(category, action, label, value)}
50eff83
@deadprogram
The Hybrid Group member

You should not comment out lines of code. Better to instead remove them entirely, and let version control do its job.

@deadprogram
The Hybrid Group member

You should not change the version number of a gem with submitting a pull request. Instead, let the gem author decide on what to include in any particular release, since there may be multiple pull requests going into it.

@PikachuEXE

Is this PR fine except the mentioned problems?
Hope @justindossey can update it soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.