add func InitUndistortRectifyMap #405
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #405 +/- ##
==========================================
+ Coverage 94.78% 94.85% +0.06%
==========================================
Files 17 17
Lines 1821 1845 +24
==========================================
+ Hits 1726 1750 +24
Misses 83 83
Partials 12 12
Continue to review full report at Codecov.
|
| @@ -66,3 +66,27 @@ func FisheyeUndistortImageWithParams(distorted Mat, undistorted *Mat, k, d, knew | |||
| } | |||
| C.Fisheye_UndistortImageWithParams(distorted.Ptr(), undistorted.Ptr(), k.Ptr(), d.Ptr(), knew.Ptr(), sz) | |||
| } | |||
|
|
|||
| // https://docs.opencv.org/master/d9/d0c/group__calib3d.html#ga7dfb72c9cf9780a347fbe3d1c47e5d5a | |||
| func InitUndistortRectifyMap(cameraMatrix Mat, distCoeffs Mat, r Mat, newCameraMatrix Mat, size image.Point, m1type int, map1 Mat, map2 Mat) { | |||
There was a problem hiding this comment.
Can you please add the GoDoc compatible comment format here?
// InitUndistortRectifyMap [description of what it does...]
//
// For further details, please see:
// ([ink to the OpenCV docs, like you have now]
//Thanks!
|
|
||
| // remember Close the Mat object | ||
| // https://docs.opencv.org/master/d9/d0c/group__calib3d.html#ga7a6c4e032c97f03ba747966e6ad862b1 | ||
| func GetOptimalNewCameraMatrixWithParams(cameraMatrix Mat, distCoeffs Mat, imageSize image.Point, alpha float64, newImgSize image.Point, centerPrincipalPoint bool) (Mat, image.Rectangle) { |
There was a problem hiding this comment.
Same as previous comment. Thank you.
There was a problem hiding this comment.
@deadprogram done
calib3d.go
Outdated
| @@ -66,3 +66,33 @@ func FisheyeUndistortImageWithParams(distorted Mat, undistorted *Mat, k, d, knew | |||
| } | |||
| C.Fisheye_UndistortImageWithParams(distorted.Ptr(), undistorted.Ptr(), k.Ptr(), d.Ptr(), knew.Ptr(), sz) | |||
| } | |||
|
|
|||
| // initUndistortRectifyMap computes the joint undistortion and rectification transformation and represents the result in the form of maps for remap | |||
There was a problem hiding this comment.
This needs to be capitalized for GoDocs to correctly use them.
calib3d.go
Outdated
|
|
||
| // initUndistortRectifyMap computes the joint undistortion and rectification transformation and represents the result in the form of maps for remap | ||
| // For more details, please see: | ||
|
|
There was a problem hiding this comment.
This cannot be a blank line for GoDocs to correctly use them.
calib3d.go
Outdated
| // GetOptimalNewCameraMatrixWithParams computes and returns the optimal new camera matrix based on the free scaling parameter. | ||
| // please remember Close the Mat object which returns | ||
| // For more details, please see: | ||
|
|
There was a problem hiding this comment.
This also cannot be a blank line.
|
Hi @linyongzuo thanks for the changes. I requested a couple more changee because GoDocs is somewhat strict about how it parses the comments. |
|
Thank you for the updates and contribution @linyongzuo now merging. |
No description provided.