Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation to composable-glsl-functions.js #28

Merged
merged 4 commits into from
Nov 6, 2019

Conversation

ssssam
Copy link
Contributor

@ssssam ssssam commented Nov 3, 2019

The goal is to automatically generate Hydra's function documentation from this file. So, the main change is to add description and example fields to each of the public functions, with contents taken from hydra docs/funcs.md.

I did some reformatting too as I was finding the file hard to work with -- mainly trying to normalize indent, and increase the amount of content that can fit on the screen at once by removing some line breaks.

Try to stick to 2 spaces for indent.
This makes the file more readable in my opinion as more context can fit
on the screen at once.
See hydra.git for corresponding changes to generate the .md
documentation from this file.

This commit was generated semi automatically, like this:

 1. convert docs/funcs.md to HTML using pandoc
 2. parse the html using beautifulsoup4 to extract description and
    example text
 3. generate a sed script to modify the .js file
Some improvements to the autogenerated docs.
@ojack
Copy link
Member

ojack commented Nov 6, 2019

Hi,

I get an error just running the initial example npm run example with these changes. Will look more into it, but it seems to be changing the name of some of the uniforms, and that is throwing an error when the shader is compiled. Holding off on merging and also on updating https://github.com/ojack/hydra/pull/65 until this is solved. In general this is great, though!

@ojack ojack merged commit 887f5d2 into hydra-synth:master Nov 6, 2019
@ojack
Copy link
Member

ojack commented Nov 6, 2019

Fixed with 6526134 :)

@ssssam ssssam deleted the sam/docs branch December 9, 2019 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants