hydra commented on pull request cleanflight/cleanflight#852
@hydra

great, reviewing now.

@hydra
hydra merged pull request cleanflight/cleanflight#1258
@hydra
Fix false RX loss detection on EEPROM read/write
1 commit with 28 additions and 0 deletions
hydra commented on pull request cleanflight/cleanflight#1258
@hydra

I will merge this now, i still don't like the approach but it'll do for now and we can improve it in future.

hydra commented on pull request cleanflight/cleanflight#1279
@hydra

i tried this link but it redirected to the home page.

hydra commented on pull request cleanflight/cleanflight#1279
@hydra

PA2 is duplicated here.

@hydra
@hydra
Flight - Vtail4 Prop Direction and Mixer Incorrect
@hydra
New servo settings (smix) not persistent across all profiles
hydra commented on pull request cleanflight/cleanflight#1255
@hydra

@ProDrone I will look into this ASAP.

hydra closed pull request cleanflight/cleanflight#1259
@hydra
Updated Custom Mixer Examples with CMIX instead of MMIX
hydra commented on pull request cleanflight/cleanflight#1259
@hydra

This pull request is invalid. the current documentation is correct for 1.10.x. Thanks anyway though!

hydra commented on pull request cleanflight/cleanflight#1276
@hydra

@fftunes Any update on testing?

hydra commented on issue cleanflight/cleanflight#1266
@hydra

yes correct. the plot thickens.

hydra commented on issue cleanflight/cleanflight#1266
@hydra

i think you need another method that updates those 'slow' fields. it's likely that you're logging the data between the time the flag is reset after…

hydra commented on issue cleanflight/cleanflight#1266
@hydra

awesome. it depends where you log it. I'll look at your implementation.

@hydra
Blackbox - Strange motor output in logs.
@hydra
Blackbox - Add logging of critical rx loss state flags.
hydra commented on pull request cleanflight/cleanflight#1258
@hydra

Notes from IRC: [19:48] <Hydra_> it seems like it's in the wrong place [19:50] <Hydra_> shouldn't the check for skipSamples be in calculateRxChann…

hydra commented on issue cleanflight/cleanflight#1260
@hydra

Yes, the code for 3D flight needs improvement.

hydra commented on issue cleanflight/cleanflight#1261
@hydra

Have you tried changing it yourself? Can it even be sent quicker? Is there enough bandwidth?

hydra commented on issue cleanflight/cleanflight#1264
@hydra

(It's coming, first things first)

@hydra
how can i do RTH on Failsafe RX Loss range?
hydra commented on issue cleanflight/cleanflight#1264
@hydra

Duplicate, see #852

hydra commented on pull request cleanflight/cleanflight#852
@hydra

Perhaps a constant instead of magic number 0 and a comment?

hydra commented on pull request cleanflight/cleanflight#852
@hydra

duplicate test setup code can be removed. See RcControlsAdjustmentsTest::SetUp() It looks like there might be some duplicate configuration of contr…

hydra commented on pull request cleanflight/cleanflight#852
@hydra

counters everywhere! yes. the failsafe needs to move away from counters and release itself from expected call frequency problem it has.

hydra commented on pull request cleanflight/cleanflight#852
@hydra

Again we can see that the FIXME and the use of the counter is having a negative impact even on the tests, the test should be manipulating the respo…