More tests, add filename to Torrent, fast Database#include? method
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I suggest so squash something if you can and eventually fix |
| @@ -0,0 +1,5 @@ | |||
| nguage: ruby | |||
|
For me now we're ok 👍 @hydride0? |
|
Please wait until a patch for this issue is added (test has to be un-skipped and code modified to guarantee uniqueness) |
|
Ok, fixed the filename non-uniqueness. Ok for me too. |
|
Good, can you also squash something too? There a lots of commits there. Then let's wait for @hydride0. |
Torrent.filename: it'll contain the path a torrent was downloaded to. Add tests: Yamazaki now has more tests, covering the usual behaviour of the library. A travis.yml has been added too. `Database#size` returns the number of saved items inside the database.
…database also refactor spec_helper a bit
Switching to Array#bsearch (with database sorting) makes yamazaki a lot faster (25-56x)
ruby1.9.3 is removed because `Array#bsearch` is not supported from <2.x ruby releases Roxas noticed a lot of imperfections and little problems, they're fixed now.
Filenames should be considered unique in the database, so duplicates are not allowed. If duplicates are present in the source file, they won't be deleted after the JSON load (and it would be very, very time consuming to do this, unless we switch to hashtables).
Fake database files were created under `/tmp`, and it may break compatibility with non-posix platform. Moreover they were not deleted, leaving a lot of random files around: now they are.
winterthediplomat
force-pushed
the
master
branch
from
669ef4f to
686ec74
Compare
|
squashed and forced things, is it ok for you @RoxasShadow ? |
|
👍 |
hydride0
added a commit
that referenced
this pull request
Oct 19, 2015
More tests, add `filename` to Torrent, fast Database#include? method
|
\o/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry I did not make separated Pull Requests, but I got carried out and pushed too much.
This PR adds some tests (and travis-ci support!) to yamazaki libraries.
filenameto Torrent classThis modification is needed for some modifications in Miyuki, but it may be useful for several clients who just want to know where are the downloaded torrents.
Database#include?methodTrack databases will only grow larger and larger, even though the rate is low. It should be noted that clients will perform more searches than insertions, so a faster
#includeis key to a faster Yamazaki. Yes, 56x faster.Unfortunately, the modification requires
Array#bsearch, which is available only on ruby 2.x. Let me know if you think it has to be compatible with 1.9.x rubies (still shipped by LTS linux distros), we can get around it.