Add datalog frontend via a proc macro #155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadaj
force-pushed
the
datalog-compiler
branch
2 times, most recently
from
2e6adb9 to
6eebb2a
Compare
shadaj
force-pushed
the
datalog-compiler
branch
from
e54ada0 to
5c62cbe
Compare
shadaj
force-pushed
the
datalog-compiler
branch
3 times, most recently
from
6de39f3 to
3ef6e89
Compare
shadaj
force-pushed
the
datalog-compiler
branch
from
5f61d6e to
7b0f8a3
Compare
Member
MingweiSamuel
left a comment
MingweiSamuel
left a comment
There was a problem hiding this comment.
Nice!!
Couple comments before diving in:
let (in_send, in_recv) = tokio::sync::mpsc::unbounded_channel::<(usize, usize)>();
...
.input in
Wouldn't it make sense to make the input .input in_recv so no _send/_recv convention needs to be enforced?
- Snapshot testing will be fragile and the codegen will definitely change in the future so we should eventually find a better way to test
Member
Author
|
Yeah perhaps we should snashot test the surface syntax or something higher level. Since we do have runtime tests, snapshots are mostly for my sanity of manually inspecting how changes affect different examples. |
MingweiSamuel
approved these changes
Aug 23, 2022
Member
MingweiSamuel
left a comment
MingweiSamuel
left a comment
There was a problem hiding this comment.
Would be good to have some high-level comments through the big function. Or split into a few smaller functions if that makes sense.
got a bit nit-ey in the review :P
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 24, 2024
* Implement parser for datalog and set up proc macro infra * Eliminate boxing of fields in Datalog grammar * Allow Souffle style trailing dot * Update rust-sitter * Initial graph creation logic * Update snapshots * Update to latest main * cargo fmt * Initial hacked up join implementation * Properly handle target bindings * Fix rules without a join * Move grammar to separate file * Add tees so that relations can be used multiple times * Fix other tests * Tee all relations * Support multiple contributors to one relation * Add transitive closure test * Support single column relations * Emit outputs to mpsc * Don't augment input/output names * Expand transitive closure test * Add join-with-self test that requires deterministic codegen * Address feedback * Extract join generation logic to a separate function * Eliminate assumption of usize columns * Rename datalog_compiler => hydroflow_datalog
nickjiang2378
pushed a commit
to nickjiang2378/hydroflow
that referenced
this pull request
Jan 25, 2024
* Implement parser for datalog and set up proc macro infra * Eliminate boxing of fields in Datalog grammar * Allow Souffle style trailing dot * Update rust-sitter * Initial graph creation logic * Update snapshots * Update to latest main * cargo fmt * Initial hacked up join implementation * Properly handle target bindings * Fix rules without a join * Move grammar to separate file * Add tees so that relations can be used multiple times * Fix other tests * Tee all relations * Support multiple contributors to one relation * Add transitive closure test * Support single column relations * Emit outputs to mpsc * Don't augment input/output names * Expand transitive closure test * Add join-with-self test that requires deterministic codegen * Address feedback * Extract join generation logic to a separate function * Eliminate assumption of usize columns * Rename datalog_compiler => hydroflow_datalog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.