Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Midi Input - hihat foot pressure #167

Merged
merged 11 commits into from Aug 4, 2014

Conversation

Projects
None yet
2 participants
@blablack
Copy link
Contributor

commented Apr 23, 2014

A patch to manage the hihat foot pressure and enable using different instruments depending on it:

  • instruments can be configured to be part of a hihat set
  • instruments part of a hihat set have a range corresponding to the foot pressure
  • instrument tab has been reworked to allow space for the new properties
@blablack

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2014

One point I forgot to mention. I implemented a press&hold for buttons - this allows to change values quicker (as CC go from 0 to 127).

@mauser

This comment has been minimized.

Copy link
Member

commented Apr 27, 2014

Just for completeness, my reply from the mailing list regarding this request:

This looks great! I have no midi pedal here to make a "real" test, but the code looks good. I'm not sure if the gui should stay this way or if we should reorganise all midi settings in a complete new window/dialog, but it is a pretty good for the moment. I will merge it as soon as the next release candidate is released and a new development path (for whats becoming 0.9.7) has been created.

@mauser mauser merged commit 34f641e into hydrogen-music:master Aug 4, 2014

@mauser

This comment has been minimized.

Copy link
Member

commented on 5095411 Aug 5, 2014

@blablack : I've reverted this commit because it caused on my system on some buttons (like the "add pattern" button in the songeditor) the firing of the "click"-event in an inifite loop, so the dialog opened directly again after i closed it.

This comment has been minimized.

Copy link
Member

replied Aug 5, 2014

@blablack : Another thing, but not soo important ;-) Could you use tabs for indentation in your code? I know that there are places in hydrogen were tabs and spaces are mixed, but we would like to try to go for tabs in new code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.