Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Avoid cffi build process if not necessary #20
Current coverage is 100% (diff: 100%)
@@ master #20 diff @@ =================================== Files 7 7 Lines 141 141 Methods 0 0 Messages 0 0 Branches 15 15 =================================== Hits 141 141 Misses 0 0 Partials 0 0
I guess this can only be tested if a new version is here: https://pypi.python.org/pypi/argon2_cffi
I see the same error, but AFAIK the version on pypi is still the one without the fix.
Yes, the branch seems to work. Here is what I did:
Nov 7, 2016
6 checks passed
I say "thank you". I ask myself why packaging does required coding. In theory a package should only provide data. I have not understood packaging python modules up to now. I am unsure if I every will understand it.
What is missing from setuptools/distutils/whateverlibrary for you to make packaging argon2_cffi a data only thing (without coding)?
It’s a bit more difficult for macOS & Windows but argon2-cffi does ship them. Linux wheels are a rather recent development and the next release of argon2-cffi will ship them too if everything goes like I wanted it to do.
For that matter, I hope your PyPI mirror (have you tried devpi btw? we’re using it with great success) is wheel aware. Recent
The reason we fixed this anyway is that sdist (source distributions) that require the execution of setup.py to gain meta data will always be around for now. (there are efforts to change that but we’ll have to see what comes out of it)