Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PositionalArgumentsFormatter does not remove empty list of args #82

Closed
keis opened this issue Sep 28, 2016 · 1 comment
Closed

PositionalArgumentsFormatter does not remove empty list of args #82

keis opened this issue Sep 28, 2016 · 1 comment

Comments

@keis
Copy link

@keis keis commented Sep 28, 2016

PositionalArgumentsFormatter with remove_positional_args=True is supposed to remove the positional_args from the event dict. However this only happens when positional_args is truthy which is not the case for the empty list. _proxy_to_logger takes care not to add these to begin with but you can still hit this unexpected behaviour if setting this attribute somewhere else. In my case using a stdlib logging handler to funnel messages into structlog.

@hynek hynek closed this in e4731ba Apr 24, 2017
@hynek
Copy link
Owner

@hynek hynek commented Apr 24, 2017

This should be fixed now. Sorry for the lack of feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants