Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make default=_json_fallback_handlerer overridable in JSONRenderer. #163

merged 2 commits into from Apr 21, 2018


Copy link

@groner groner commented Apr 20, 2018

This addresses #77. I don't think there are any documentation concerns here as JSONRenderer already relays extra keyword args to dumps.

Copy link

@codecov codecov bot commented Apr 20, 2018

Codecov Report

Merging #163 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #163   +/-   ##
  Coverage     100%   100%           
  Files          13     13           
  Lines         813    814    +1     
  Branches      105    105           
+ Hits          813    814    +1
Impacted Files Coverage Δ
src/structlog/ 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b854e7...07ad6c2. Read the comment docs.

Copy link

@hynek hynek commented Apr 21, 2018

Well that’s certainly a possible approach. :)

I’m gonna disagree on the documentation part tho, because it’s not obvious what’s happening here.

It’s even fair to say that currently the docs are very much lacking. But I guess I can fix that myself.


@hynek hynek merged commit 950bfdc into hynek:master Apr 21, 2018
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 100%)
codecov/project 100% (+0%) compared to 8b854e7
continuous-integration/travis-ci/pr The Travis CI build passed
hynek added a commit that referenced this pull request Apr 21, 2018
Copy link
Contributor Author

@groner groner commented May 15, 2018

Hi @hynek. Thanks for merging and documenting this.

Is there anything I can do to help prepare a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants