Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleRenderer: default to colorless when colorama is unavailable #215

Merged
merged 2 commits into from Aug 15, 2019

Conversation

danchr
Copy link
Contributor

@danchr danchr commented May 24, 2019

colorama isn't a direct dependency of structlog, and as such it might not be available. The console renderer should still work when it isn't, though.

'colorama' isn't a direct dependency of 'structlog', and as such it
might not be available. The console renderer should still work when it
isn't, though.
@danchr danchr force-pushed the consolerenderer-defaults branch from bb2ce09 to 8b65742 Compare Jun 24, 2019
hynek
hynek approved these changes Aug 15, 2019
Copy link
Owner

@hynek hynek left a comment

Thank you, this makes a lot of sense! Sorry I didn't get back to you sooner.

@hynek hynek merged commit 84da16a into hynek:master Aug 15, 2019
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants