Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsoleRenderer: default to colorless when colorama is unavailable #215

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@danchr
Copy link
Contributor

danchr commented May 24, 2019

colorama isn't a direct dependency of structlog, and as such it might not be available. The console renderer should still work when it isn't, though.

'colorama' isn't a direct dependency of 'structlog', and as such it
might not be available. The console renderer should still work when it
isn't, though.
@danchr danchr force-pushed the danchr:consolerenderer-defaults branch from bb2ce09 to 8b65742 Jun 24, 2019
@hynek
hynek approved these changes Aug 15, 2019
Copy link
Owner

hynek left a comment

Thank you, this makes a lot of sense! Sorry I didn't get back to you sooner.

@hynek hynek merged commit 84da16a into hynek:master Aug 15, 2019
22 checks passed
22 checks passed
codecov/patch Coverage not affected when comparing 0e209d9...54fda5f
Details
codecov/project 100% (target 100%)
Details
hynek.structlog Build #20190815.2 succeeded
Details
hynek.structlog (Test Docs) Test Docs succeeded
Details
hynek.structlog (Test Lint) Test Lint succeeded
Details
hynek.structlog (Test Manifest) Test Manifest succeeded
Details
hynek.structlog (Test PyPI-Description) Test PyPI-Description succeeded
Details
hynek.structlog (Test py27-colorama) Test py27-colorama succeeded
Details
hynek.structlog (Test py27-greenlets) Test py27-greenlets succeeded
Details
hynek.structlog (Test py27-oldtwisted) Test py27-oldtwisted succeeded
Details
hynek.structlog (Test py27-threads) Test py27-threads succeeded
Details
hynek.structlog (Test py35-threads) Test py35-threads succeeded
Details
hynek.structlog (Test py36-threads) Test py36-threads succeeded
Details
hynek.structlog (Test py37-colorama) Test py37-colorama succeeded
Details
hynek.structlog (Test py37-greenlets) Test py37-greenlets succeeded
Details
hynek.structlog (Test py37-oldtwisted) Test py37-oldtwisted succeeded
Details
hynek.structlog (Test py37-threads) Test py37-threads succeeded
Details
hynek.structlog (Test pypy-colorama) Test pypy-colorama succeeded
Details
hynek.structlog (Test pypy-greenlets) Test pypy-greenlets succeeded
Details
hynek.structlog (Test pypy-oldtwisted) Test pypy-oldtwisted succeeded
Details
hynek.structlog (Test pypy-threads) Test pypy-threads succeeded
Details
hynek.structlog (Test pypy3-threads) Test pypy3-threads succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.