Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger argument to ProcessorFormatter #219

Merged
merged 9 commits into from Aug 15, 2019

Conversation

rasto2211
Copy link
Contributor

@rasto2211 rasto2211 commented Jul 24, 2019

filter_by_level processor needs logger object in order to find out what is the log level. Add logger as an argument to ProcessorFormatter and then pass it through the processor chain so filter_by_level can use it.

Related to #195

Copy link
Owner

@hynek hynek left a comment

While I'm unhappy with the extra if statement, I guess we'll have to live with it and it looks pretty good otherwise. There's a few docs nibbles that I'd like you to fix, but then it's ready for merge. Thanks!

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
src/structlog/stdlib.py Outdated Show resolved Hide resolved
hynek
hynek approved these changes Aug 15, 2019
Copy link
Owner

@hynek hynek left a comment

Thanks!

@hynek hynek merged commit 0e209d9 into hynek:master Aug 15, 2019
22 checks passed
@rasto2211 rasto2211 deleted the rasto/processor-formatter branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants