Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesAdd logger argument to ProcessorFormatter #219
+33
−5
Conversation
|
While I'm unhappy with the extra if statement, I guess we'll have to live with it and it looks pretty good otherwise. There's a few docs nibbles that I'd like you to fix, but then it's ready for merge. Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rasto2211 commentedJul 24, 2019
filter_by_levelprocessor needs logger object in order to find out what is the log level. Addloggeras an argument toProcessorFormatterand then pass it through the processor chain sofilter_by_levelcan use it.Related to #195