Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger argument to ProcessorFormatter #219

Merged
merged 9 commits into from Aug 15, 2019

Conversation

@rasto2211
Copy link
Contributor

rasto2211 commented Jul 24, 2019

filter_by_level processor needs logger object in order to find out what is the log level. Add logger as an argument to ProcessorFormatter and then pass it through the processor chain so filter_by_level can use it.

Related to #195

rasto2211 added 6 commits Jul 24, 2019
This reverts commit 8088d6f.
This reverts commit 4d7e3ea.
Copy link
Owner

hynek left a comment

While I'm unhappy with the extra if statement, I guess we'll have to live with it and it looks pretty good otherwise. There's a few docs nibbles that I'd like you to fix, but then it's ready for merge. Thanks!

CHANGELOG.rst Outdated Show resolved Hide resolved
CHANGELOG.rst Outdated Show resolved Hide resolved
src/structlog/stdlib.py Outdated Show resolved Hide resolved
rasto2211 added 3 commits Aug 7, 2019
@hynek
hynek approved these changes Aug 15, 2019
Copy link
Owner

hynek left a comment

Thanks!

@hynek hynek merged commit 0e209d9 into hynek:master Aug 15, 2019
22 checks passed
22 checks passed
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (target 100%)
Details
hynek.structlog Build #20190807.2 succeeded
Details
hynek.structlog (Test Docs) Test Docs succeeded
Details
hynek.structlog (Test Lint) Test Lint succeeded
Details
hynek.structlog (Test Manifest) Test Manifest succeeded
Details
hynek.structlog (Test PyPI-Description) Test PyPI-Description succeeded
Details
hynek.structlog (Test py27-colorama) Test py27-colorama succeeded
Details
hynek.structlog (Test py27-greenlets) Test py27-greenlets succeeded
Details
hynek.structlog (Test py27-oldtwisted) Test py27-oldtwisted succeeded
Details
hynek.structlog (Test py27-threads) Test py27-threads succeeded
Details
hynek.structlog (Test py35-threads) Test py35-threads succeeded
Details
hynek.structlog (Test py36-threads) Test py36-threads succeeded
Details
hynek.structlog (Test py37-colorama) Test py37-colorama succeeded
Details
hynek.structlog (Test py37-greenlets) Test py37-greenlets succeeded
Details
hynek.structlog (Test py37-oldtwisted) Test py37-oldtwisted succeeded
Details
hynek.structlog (Test py37-threads) Test py37-threads succeeded
Details
hynek.structlog (Test pypy-colorama) Test pypy-colorama succeeded
Details
hynek.structlog (Test pypy-greenlets) Test pypy-greenlets succeeded
Details
hynek.structlog (Test pypy-oldtwisted) Test pypy-oldtwisted succeeded
Details
hynek.structlog (Test pypy-threads) Test pypy-threads succeeded
Details
hynek.structlog (Test pypy3-threads) Test pypy3-threads succeeded
Details
@rasto2211 rasto2211 deleted the rasto2211:rasto/processor-formatter branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.