Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capture_logs context manager #234

Merged
merged 4 commits into from Jan 6, 2020
Merged

Add capture_logs context manager #234

merged 4 commits into from Jan 6, 2020

Conversation

rgalanakis
Copy link
Contributor

@rgalanakis rgalanakis commented Dec 12, 2019

See #14 (comment)
for more context.

It needed to go into its own file, rather than dev,
because it relies on _config and _config relies on dev.

@rgalanakis rgalanakis force-pushed the master branch 2 times, most recently from 699db54 to 27a66c1 Compare Dec 12, 2019
See hynek#14 (comment)
for more context.

It needed to go into its own file, rather than `dev`,
because it relies on `_config` and `_config` relies on `dev`.
@hynek
Copy link
Owner

@hynek hynek commented Dec 12, 2019

I would suggest to create a module called structlog.testing. Maybe we'll find more testing helpers over the time.

@rgalanakis
Copy link
Contributor Author

@rgalanakis rgalanakis commented Dec 12, 2019

Ok, renamed it. I also made LogCapture available for public use, and documented the pytest fixture use case.

@hynek hynek merged commit f34659d into hynek:master Jan 6, 2020
21 checks passed
@hynek
Copy link
Owner

@hynek hynek commented Jan 6, 2020

Thank you very much, I'll fix the version number myself . #procrastinatorExtraordinaire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants