Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #201 - Add support for contextvars #236

Merged
merged 3 commits into from Jan 7, 2020
Merged

Conversation

MarkusH
Copy link
Contributor

@MarkusH MarkusH commented Dec 23, 2019

This PR basically turns #201 (comment) into something mergeable.

Open question: How do I cleverly exclude the test_contextvars.py file on all Python 2 versions?

@hynek
Copy link
Owner

@hynek hynek commented Dec 24, 2019

Weee, what a xmas gift! ❤️

I'm not sure if there's a better way nowadays, but you can use this approach from attrs.

@MarkusH
Copy link
Contributor Author

@MarkusH MarkusH commented Dec 24, 2019

Weee, what a xmas gift! ❤️

Merry Christmas 🎄 🙂

I'm not sure if there's a better way nowadays, but you can use this approach from attrs.

That's exactly what I was looking for, I think.

@hynek hynek merged commit 748fb32 into hynek:master Jan 7, 2020
21 checks passed
@hynek
Copy link
Owner

@hynek hynek commented Jan 7, 2020

Thanks, only fitting to merge it on Orthodox Christmas! ;)

@MarkusH MarkusH deleted the contextvars branch Jan 7, 2020
@MarkusH
Copy link
Contributor Author

@MarkusH MarkusH commented Jan 7, 2020

Thank you ❤️

hynek added a commit that referenced this issue Jan 8, 2020
The two `context` in merge_context_local_context may look weird but they refer
to two different contexts...
@WouldYouKindly
Copy link

@WouldYouKindly WouldYouKindly commented Feb 1, 2020

This was the only thing that stopped me from trying out structlog. Thank you both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants