Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't be lazy on Windows #242

Merged
merged 2 commits into from Jan 28, 2020
Merged

Don't be lazy on Windows #242

merged 2 commits into from Jan 28, 2020

Conversation

hynek
Copy link
Owner

@hynek hynek commented Jan 25, 2020

Fixes #232

Could you check if this helps @wimglenn?

I've decided to go the grossest possible route: non-lazy on Windows, lazy everywhere else…

cc @MarkusH

@MarkusH
Copy link
Contributor

@MarkusH MarkusH commented Jan 25, 2020

I don't have a Windows at hand right now. I can check the next days :)

@wimglenn
Copy link

@wimglenn wimglenn commented Jan 28, 2020

@hynek I wasn't able to install your package on windows, something in the regex must be platform dependent (perhaps it's due to hardcoded \n endings in this pattern - the changelog text will have \r\n the way you've defined the read function, so the pattern doesn't match anything)

C:\...\structlog> python setup.py
Traceback (most recent call last):
  File "setup.py", line 100, in <module>
    + re.search(
AttributeError: 'NoneType' object has no attribute 'group'

However, I can confirm the fix works on Windows. I was able to test this just by cd into the ./src directory and checking out the lazy-win-hack branch.

No shame in the "gross" route for windows - a dumb conditional is also how I deal with colorama init for cross-platform.

@hynek hynek merged commit a1da7e5 into master Jan 28, 2020
21 checks passed
@hynek hynek deleted the lazy-win-hack branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants