Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stdlib.BoundLogger.log #42

Merged
merged 2 commits into from Jan 21, 2015
Merged

Add stdlib.BoundLogger.log #42

merged 2 commits into from Jan 21, 2015

Conversation

@hynek
Copy link
Owner

@hynek hynek commented Jan 21, 2015

Should fix #36?

@hynek hynek force-pushed the add-log branch from e2c9558 to 3731254 Jan 21, 2015
@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2015

Coverage Status

Changes Unknown when pulling 3731254 on add-log into * on master*.

@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2015

Coverage Status

Changes Unknown when pulling 3731254 on add-log into * on master*.

@wbolster
Copy link

@wbolster wbolster commented Jan 21, 2015

Without actually having tested it, this looks good and will handle the "standard" cases where the standard log levels are used. This probably covers most use cases, e.g. where the log level is dynamically determined and passed in as an argument to .log(...).

However, the tricky part is when non-standard log levels are used. This is what I hinted at when I said I quickly gave up in #36. The stdlib supports defining custom log levels: https://docs.python.org/3/library/logging.html#levels

But perhaps structlog should just not support that. :)

@coveralls
Copy link

@coveralls coveralls commented Jan 21, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 3731254 on add-log into 54f98e8 on master.

@hynek
Copy link
Owner Author

@hynek hynek commented Jan 21, 2015

Well, if someone wants them, they’ll have to implement it. :)

hynek added a commit that referenced this pull request Jan 21, 2015
Add stdlib.BoundLogger.log
@hynek hynek merged commit 203cc04 into master Jan 21, 2015
1 check failed
1 check failed
continuous-integration/travis-ci The Travis CI build failed
Details
@hynek hynek deleted the add-log branch May 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants