/structlog

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify key in TimeStamper processor #51

Merged
merged 2 commits into from Mar 16, 2015

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@leplatrem @coveralls @hynek
@leplatrem
Contributor

leplatrem commented Mar 13, 2015

In my environment, the logging standard is to store the human-readable timestamp in a 'time' entry :)
@coveralls

This comment has been minimized.

Sign in to view

coveralls commented Mar 13, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling ccfec64 on leplatrem:specify_key_in_timestamper into d6dfd8f on hynek:master.
structlog/processors.py Outdated
@@ -207,36 +207,37 @@ class TimeStamper(object):
<http://en.wikipedia.org/wiki/ISO_8601>`_, or `None` for a `UNIX
timestamp <http://en.wikipedia.org/wiki/Unix_time>`_.
:param bool utc: Whether timestamp should be in UTC or local time.
:param str key: Property name stored in `event_dict`.

This comment has been minimized.

Sign in to view
Copy link
@hynek

hynek Mar 14, 2015

Owner

I don’t think ”Property” is the right term here. Maybe something like “Target key in event_dict for added timestamps.”?
@hynek

This comment has been minimized.

Sign in to view
Owner

hynek commented Mar 14, 2015

Please:

Thanks!
@leplatrem
Conform with contribution guidelines 
/cc @hynek
Loading status checks…
d0ce8c0
@coveralls

This comment has been minimized.

Sign in to view

coveralls commented Mar 16, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling d0ce8c0 on leplatrem:specify_key_in_timestamper into d6dfd8f on hynek:master.
@hynek

This comment has been minimized.

Sign in to view
Owner

hynek commented Mar 16, 2015

Thanks! I was about to complain about <unreleased> but it actually works well. I need to redo the changelog ASAP. :-/

hynek added a commit that referenced this pull request Mar 16, 2015

@hynek
Merge pull request #51 from leplatrem/specify_key_in_timestamper 
Add option to specify key in TimeStamper processor
Loading status checks…
0a90029

@hynek hynek merged commit 0a90029 into hynek:master Mar 16, 2015
1 check passed

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment