Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upDon't cache logger #72
Conversation
glasserc
added some commits
May 23, 2016
glasserc
referenced this pull request
May 23, 2016
Closed
PrintLogger' object has no attribute 'isEnabledFor' #628
This comment has been minimized.
This comment has been minimized.
|
Hm, I’d love to know why Travis is not picking up this change. I think GitHub reported some problems today. Could you please add a docstring to the test in the style of https://jml.io/pages/test-docstrings.html ? I know that old tests don’t have them but I require them for new ones. Makes it much easier to understand. Thanks! |
This comment has been minimized.
This comment has been minimized.
codecov-io
commented
May 23, 2016
•
Current coverage is 100%@@ master #72 diff @@
==========================================
Files 13 13
Lines 694 695 +1
Methods 0 0
Messages 0 0
Branches 88 88
==========================================
+ Hits 694 695 +1
Misses 0 0
Partials 0 0
|
This comment has been minimized.
This comment has been minimized.
|
I've pushed a docstring and some flake8 fixes. Please let me know of any other improvements you'd like to see. |
hynek
merged commit b6236d4
into
hynek:master
May 23, 2016
This comment has been minimized.
This comment has been minimized.
|
thanks! |
This was referenced May 24, 2016
This comment has been minimized.
This comment has been minimized.
Natim
commented
May 24, 2016
|
@hynek Do you think it would be possible to build a patch release with this on pypi? |
glasserc
deleted the
glasserc:dont-cache-logger
branch
May 24, 2016
glasserc
referenced this pull request
May 24, 2016
Closed
Remove structlog initialization hack when new version is released #644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
glasserc commentedMay 23, 2016
Fix #71 by not caching any part of the configuration in the proxy unless explicitly requested. This makes the
_loggerattribute consistent with other parameters of the BoundLoggerLazyProxy such as_processors,_wrapper_class, and_context_class.