New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to switch coloring output in ConsoleRenderer #78

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@insolite

insolite commented Aug 28, 2016

Could be useful for plain text file output.

@codecov-io

This comment has been minimized.

codecov-io commented Aug 28, 2016

Current coverage is 100% (diff: 100%)

Merging #78 into master will not change coverage

@@           master   #78   diff @@
===================================
  Files          13    13          
  Lines         695   701     +6   
  Methods         0     0          
  Messages        0     0          
  Branches       88    88          
===================================
+ Hits          695   701     +6   
  Misses          0     0          
  Partials        0     0          

Powered by Codecov. Last update 1bfa171...afb175b

@hynek

This comment has been minimized.

Owner

hynek commented Aug 29, 2016

So in principle, I always wanted ConsoleRenderer make the default (the default config and .dev aren’t part of any backward compatibility promises), how about we make it default and if colorama is missing, it switches automatically to colorize=False (although I think we should it call just colors) and emits a warning?

Do not require colorama when not using colors
Emit warning instead of exception when colorama is unavailable and  force switch `colors` to `False`
@insolite

This comment has been minimized.

insolite commented Aug 29, 2016

Yes, sounds good. I've commited all that things above.

@hynek

This comment has been minimized.

Owner

hynek commented Sep 17, 2016

I took a slightly different route but thanks for the inspiration!

hynek added a commit that referenced this pull request Sep 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment