Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix stdlib errors being logged as exceptions sometimes. #92
stdlib error log records were sometimes logged with exception level, sometimes
The problem is that once the mistake is done, it's pretty complicated to debug.
Current coverage is 100% (diff: 100%)
@@ master #92 diff @@ =================================== Files 13 13 Lines 739 753 +14 Methods 0 0 Messages 0 0 Branches 91 94 +3 =================================== + Hits 739 753 +14 Misses 0 0 Partials 0 0
Just to be 100% clear. With the previous implementation,
This means that the
You'll probably notice tat this PR does not contain any tt's not about lazyness, but this one is incredibely hard to write. The best test I could write would be a test that:
I don't write this kind of Schrödinger test, it's pointless… If you have any better idea on how to implement it, let me know.