[ENH] sktime integration - time series classification
#173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonBlanke
reviewed
Aug 27, 2025
| >>> | ||
| >>> y = load_airline() | ||
| >>> | ||
| >>> sktime_exp = SktimeForecastingExperiment( |
Collaborator
There was a problem hiding this comment.
Please update the example so that it uses the classification.
Collaborator
Author
There was a problem hiding this comment.
done, both the examples in the experiment, and the tuner
SimonBlanke
reviewed
Aug 27, 2025
| best_params = optimizer.solve() | ||
|
|
||
| self.best_params_ = best_params | ||
| self.best_forecaster_ = estimator.set_params(**best_params) |
Collaborator
There was a problem hiding this comment.
Shouldn't this be the best_classifier_?
Collaborator
Author
There was a problem hiding this comment.
changed it to best_estimator_, since we might want to use the code later for regression and clustering
SimonBlanke
requested changes
Aug 27, 2025
Collaborator
SimonBlanke
left a comment
SimonBlanke
left a comment
There was a problem hiding this comment.
Please answer the questions in the code.
Collaborator
Author
|
should be fixed now! |
SimonBlanke
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds integration for another learning task in
sktime- time series classification.SktimeClassificationExperimentexperimentTSCOptCVTSC tuning algorithm that takes anyhyperactivetunerSince time series classification uses ordinary sklearn metrics, the
experiments.integrationcontents are refactored, moving utilities concerned withsklearnmetrics into a separate, private file_skl_metrics.