V5 fixes #180
Merged
V5 fixes #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
reviewed
Sep 3, 2025
fkiraly
reviewed
Sep 3, 2025
| import numpy as np | ||
|
|
||
| # function to be maximized | ||
| def problem(opt): |
Collaborator
There was a problem hiding this comment.
would it not still work with opt too?
Collaborator
Author
There was a problem hiding this comment.
It would. "params" is better though. I previously often used "opt", because this argument was also an interface to GFO, but that is now gone.
fkiraly
reviewed
Sep 3, 2025
fkiraly
approved these changes
Sep 3, 2025
Collaborator
fkiraly
left a comment
fkiraly
left a comment
There was a problem hiding this comment.
Some comments, but none blocking
Collaborator
|
(still approve) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix examples in readme, links to examples and change intro text.