You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
✅ Overall: Clean refactoring, no critical issues found
This PR successfully extracts helper functions from the overly long processAlert function, improving readability and maintainability. The refactoring follows good practices and maintains the original logic.
Minor observations (non-blocking):
Type narrowing inconsistency: Line 380 passes !!hasGroupBy to shouldSkipAlertCheck, but the function parameter is typed as boolean and hasGroupBy is already boolean (line 377). Consider passing hasGroupBy directly for consistency.
parseAlertData parseInt behavior: Line 356 uses parseInt(v) which can silently fail or produce NaN for invalid numeric strings. Consider parseInt(v, 10) for explicit base-10 parsing or Number(v) with validation.
Missing alertId in error log: Line 507 logs "Failed to get response metadata" but could benefit from including checksData or meta in the log context for debugging (similar to line 335).
These are minor quality improvements and don't block the merge. The refactoring achieves its goal of improving code organization.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extracts a couple of functions out of the excessively long
processAlertfunction, to improve readability.This is also intended to simplify HDX-2568, which will be able to re-use some of these functions.