Skip to content

Conversation

@teeohhem
Copy link
Contributor

@teeohhem teeohhem commented Nov 7, 2025

Fixes: HDX-2789

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

🦋 Changeset detected

Latest commit: e0ac970

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Nov 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview Comment Nov 11, 2025 2:52pm

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

E2E Test Results

All tests passed • 40 passed • 3 skipped • 306s

Status Count
✅ Passed 40
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 3

View full report →

@claude
Copy link

claude bot commented Nov 7, 2025

PR Review

⚠️ UX Issue: useEffect only switches to 'all' when filter applied, but doesn't reset to 'running' when filter cleared → Update effect to handle both cases:

useEffect(() => {
  if (where) {
    setPhaseFilter('all');
  } else {
    setPhaseFilter('running');
  }
}, [where]);

⚠️ Flaky test pattern: page.waitForTimeout(500) in test → Replace with proper assertion like await expect(allTab).toBeChecked({ timeout: 5000 })

Otherwise implementation looks good - proper imports, follows React patterns, changeset added.

@kodiakhq kodiakhq bot merged commit b90a064 into main Nov 11, 2025
9 checks passed
@kodiakhq kodiakhq bot deleted the tom/kube-search-switch branch November 11, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants