From 0c673d25f884e2f1ee3ca645b39c62b38b81e184 Mon Sep 17 00:00:00 2001 From: Brandon Pereira Date: Thu, 13 Nov 2025 19:13:59 -0500 Subject: [PATCH 1/3] fix prop warnings --- packages/app/src/components/DBTable/DBRowTableIconButton.tsx | 2 ++ packages/app/src/components/SQLInlineEditor.tsx | 1 + 2 files changed, 3 insertions(+) diff --git a/packages/app/src/components/DBTable/DBRowTableIconButton.tsx b/packages/app/src/components/DBTable/DBRowTableIconButton.tsx index c409c477a..409cb176e 100644 --- a/packages/app/src/components/DBTable/DBRowTableIconButton.tsx +++ b/packages/app/src/components/DBTable/DBRowTableIconButton.tsx @@ -51,8 +51,10 @@ export const DBRowTableIconButton: React.FC = ({ > {isActive ? : children} diff --git a/packages/app/src/components/SQLInlineEditor.tsx b/packages/app/src/components/SQLInlineEditor.tsx index f7fa56846..686f53a96 100644 --- a/packages/app/src/components/SQLInlineEditor.tsx +++ b/packages/app/src/components/SQLInlineEditor.tsx @@ -327,6 +327,7 @@ export default function SQLInlineEditor({ style={{ whiteSpace: 'nowrap', }} + component="div" > From fde56e16b417c7846753ecb684f6266f6866a3c0 Mon Sep 17 00:00:00 2001 From: Brandon Pereira Date: Thu, 13 Nov 2025 19:31:27 -0500 Subject: [PATCH 2/3] add changeset --- .changeset/chatty-parents-drum.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/chatty-parents-drum.md diff --git a/.changeset/chatty-parents-drum.md b/.changeset/chatty-parents-drum.md new file mode 100644 index 000000000..6ac814ae8 --- /dev/null +++ b/.changeset/chatty-parents-drum.md @@ -0,0 +1,5 @@ +--- +"@hyperdx/app": patch +--- + +Small fix for html structure nesting issues From 8b2ff21feec757bcd19a05c9f20b14f53b28e4ff Mon Sep 17 00:00:00 2001 From: Brandon Pereira Date: Thu, 13 Nov 2025 19:55:51 -0500 Subject: [PATCH 3/3] fix failing tests --- packages/app/tests/e2e/features/shared/multiline.spec.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/app/tests/e2e/features/shared/multiline.spec.ts b/packages/app/tests/e2e/features/shared/multiline.spec.ts index 0d8daa3c4..e4fa4cbc1 100644 --- a/packages/app/tests/e2e/features/shared/multiline.spec.ts +++ b/packages/app/tests/e2e/features/shared/multiline.spec.ts @@ -110,7 +110,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => { if (config.mode === 'SQL') { const scopedContainer = formSelector ? container : page; const whereLabel = scopedContainer.locator( - `p.mantine-Text-root:has-text("${whereText}")`, + `div.mantine-Text-root:has-text("${whereText}")`, ); await expect(whereLabel).toBeVisible(); } @@ -122,7 +122,7 @@ test.describe('Multiline Input', { tag: '@search' }, () => { ? (() => { const scopedContainer = formSelector ? container : page; const whereContainer = scopedContainer.locator( - `div:has(p.mantine-Text-root:has-text("${whereText}"))`, + `div:has(div.mantine-Text-root:has-text("${whereText}"))`, ); return whereContainer.locator('.cm-editor').first(); })()