Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix method call mistake of none exists function setClient in BaseClient #541

Merged
merged 3 commits into from Sep 7, 2019

Conversation

@starfalling
Copy link
Contributor

commented Sep 6, 2019

No description provided.

@starfalling starfalling changed the title fix method call mistake of not exists function setClient in BaseClient fix method call mistake of none exists function setClient in BaseClient Sep 6, 2019

@starfalling

This comment has been minimized.

Copy link
Contributor Author

commented Sep 6, 2019

This will cause crash when BaseClient is constructed with client option set

@huangzhhui

This comment has been minimized.

Copy link
Member

commented Sep 6, 2019

Changelog 补充下

limingxinleo added 2 commits Sep 7, 2019

@limingxinleo limingxinleo merged commit 5dbf920 into hyperf-cloud:1.0 Sep 7, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@starfalling starfalling deleted the starfalling:fix-GrpcClient-setClient2 branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.