Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed the problem that grpc client Parser didn't return the correct info of standard error model #542

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@starfalling
Copy link
Contributor

commented Sep 6, 2019

No description provided.

fixed the problem that grpc client Parser didn't return the correct e…
…rror info of grpc standard error model
@limingxinleo
Copy link
Member

left a comment

这个改动需要研究一下

@limingxinleo

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

@huangzhhui 这个pr我觉得可以这么处理。用户如果需要自己处理,其实可以只拿response。前面两个字段就默认放grpc的数据

@limingxinleo

This comment has been minimized.

Copy link
Member

commented Sep 9, 2019

1.1里 。。我还是觉得额外定义一个结构体来存比较好。。数组的话不太方便定义,有时候代表http status,有时候代表grpc status,有时候代表结果。。

@huangzhhui

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

1.1里 。。我还是觉得额外定义一个结构体来存比较好。。数组的话不太方便定义,有时候代表http status,有时候代表grpc status,有时候代表结果。。

是的,这里我主要也是这个问题,就是觉得修改值的方式太过原始粗暴了,不在这个 PR 改掉吗?

@limingxinleo

This comment has been minimized.

Copy link
Member

commented Sep 10, 2019

会导致1.0版本里的用户出现问题吧。。放到 1.1 里处理吧

@limingxinleo limingxinleo requested a review from huangzhhui Sep 10, 2019

@huangzhhui
Copy link
Member

left a comment

Changelog 需要补充下

@limingxinleo limingxinleo merged commit 37bf3bf into hyperf-cloud:1.0 Sep 10, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.