Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ServerInterface::SERVER_TCP is deprecated And Fixed udp server is not works. #558

Merged
merged 5 commits into from Sep 10, 2019

Conversation

@limingxinleo
Copy link
Member

commented Sep 10, 2019

No description provided.

@limingxinleo limingxinleo changed the title Set ServerInterface::SERVER_TCP is deprecated. Set ServerInterface::SERVER_TCP is deprecated And Fixed udp server is not works. Sep 10, 2019

@limingxinleo limingxinleo requested a review from huangzhhui Sep 10, 2019

@@ -56,6 +56,7 @@ public static function build(array $config)
isset($config['type']) && $port->setType($config['type']);
isset($config['host']) && $port->setHost($config['host']);
isset($config['port']) && $port->setPort($config['port']);
isset($config['sock_type']) && $port->setSockType($config['sock_type']);

This comment has been minimized.

Copy link
@limingxinleo

limingxinleo Sep 10, 2019

Author Member

这里的 sock_type 一直没有传进来,导致配置无效,所以创建 server 时 一直传的null,就导致 udp 服务没办法使用。。。

/**
* @deprecated v1.1
*/
const SERVER_TCP = self::SERVER_BASE;

This comment has been minimized.

Copy link
@limingxinleo

limingxinleo Sep 10, 2019

Author Member

另外,这里改个名字,SERVER_TCP 不止 TCP。。。

@huangzhhui
Copy link
Member

left a comment

还缺少 Changelog

limingxinleo and others added 2 commits Sep 10, 2019

@limingxinleo limingxinleo merged commit 21a6965 into 1.0 Sep 10, 2019

3 checks passed

Tidelift Dependencies checked
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@limingxinleo limingxinleo deleted the 1.0-deprecated branch Sep 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.