From 046456fdec7f2007e320390345f09feede2fc2c0 Mon Sep 17 00:00:00 2001 From: Deeka Wong <8337659+huangdijia@users.noreply.github.com> Date: Tue, 22 Aug 2023 15:45:23 +0800 Subject: [PATCH] Optimize config --- src/tracer/publish/opentracing.php | 1 - src/tracer/src/Adapter/Reporter/Kafka.php | 12 +++--------- 2 files changed, 3 insertions(+), 10 deletions(-) diff --git a/src/tracer/publish/opentracing.php b/src/tracer/publish/opentracing.php index 514bc5a0e2c..005ef76eda5 100644 --- a/src/tracer/publish/opentracing.php +++ b/src/tracer/publish/opentracing.php @@ -43,7 +43,6 @@ 'kafka' => [ 'topic' => 'zipkin', 'bootstrap_servers' => '127.0.0.1:9092', - 'brokers' => null, 'acks' => -1, 'connect_timeout' => 1, 'send_timeout' => 1, diff --git a/src/tracer/src/Adapter/Reporter/Kafka.php b/src/tracer/src/Adapter/Reporter/Kafka.php index 12f34c321ac..fd9f12f5657 100644 --- a/src/tracer/src/Adapter/Reporter/Kafka.php +++ b/src/tracer/src/Adapter/Reporter/Kafka.php @@ -68,21 +68,15 @@ public function report(array $spans): void private function createProducer(array $options): Producer { $options = array_replace([ - 'bootstrap_servers' => null, - 'brokers' => null, + 'bootstrap_servers' => '127.0.0.1:9092', 'acks' => -1, 'connect_timeout' => 1, 'send_timeout' => 1, ], $options); $config = new ProducerConfig(); - if (! empty($options['bootstrap_servers'])) { - $config->setBootstrapServer($options['bootstrap_servers']); - $config->setUpdateBrokers(true); - } - if (! empty($options['brokers'])) { - $config->setBrokers($options['brokers']); - } + $config->setBootstrapServer($options['bootstrap_servers']); + $config->setUpdateBrokers(true); if (is_int($options['acks'])) { $config->setAcks($options['acks']); }