Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the class name of all Visitors, fixed typo #349

Merged
merged 20 commits into from Aug 7, 2019

Conversation

wenbinye
Copy link
Contributor

@wenbinye wenbinye commented Aug 7, 2019

用静态代码扫描工具查出一些问题,同时修改一些变量名拼写错误。

@huangzhhui huangzhhui changed the title Fix typo Renamed the class name of all Visitors, fixed typo Aug 7, 2019
@wenbinye
Copy link
Contributor Author

wenbinye commented Aug 7, 2019

src/database/src/DatabaseManager.php 这个文件我没有改,不熟悉。构造函数有一个参数\Hyperf\Contracts\Foundation\Application $app 是不存在的。
还有 src/database/src/Model/Model.php 第 1057 行用到的 QueueableCollection 和 QueueableEntity 都是不存在的。

其他错误:

Fatal error: The class \Hyperf\Contracts\Foundation\Application not exist in src/database/src/DatabaseManager.php on line 29
Fatal error: The class \Hyperf\Contracts\Foundation\Application not exist in src/database/src/DatabaseManager.php on line 57
Fatal error: The class QueueableCollection not exist in src/database/src/Model/Model.php on line 1057
Fatal error: The class QueueableEntity not exist in src/database/src/Model/Model.php on line 1063
Fatal error: The function database_path not exist in src/database/src/Model/Factory.php on line 72
Fatal error: The class \Hyperf\Utils\Carbon not exist in src/database/src/Model/Concerns/HasTimestamps.php on line 71
Fatal error: The class \Hyperf\Contracts\Pagination\Paginator not exist in src/database/src/Model/Builder.php on line 756
Fatal error: The class \Hyperf\Contracts\Pagination\LengthAwarePaginator not exist in src/database/src/Model/Relations/BelongsToMany.php on line 546
Fatal error: The class \Hyperf\Contracts\Pagination\Paginator not exist in src/database/src/Model/Relations/BelongsToMany.php on line 564
Fatal error: The class \Hyperf\Contracts\Pagination\LengthAwarePaginator not exist in src/database/src/Model/Relations/HasManyThrough.php on line 334
Fatal error: The class \Hyperf\Contracts\Pagination\Paginator not exist in src/database/src/Model/Relations/HasManyThrough.php on line 350
Fatal error: The class \Hyperf\Support\Collection not exist in src/database/src/Commands/Migrations/StatusCommand.php on line 79

@limingxinleo
Copy link
Member

src/database/src/DatabaseManager.php 这个文件我没有改,不熟悉。构造函数有一个参数\Hyperf\Contracts\Foundation\Application $app 是不存在的

这个是 Laravel 打包给其他 FPM框架用的,我们没有使用,也没删除而已。。

@huangzhhui
Copy link
Member

我觉得可以一并删除了 DatabaseManager,后续要做开放性的适配的时候再加回来

@limingxinleo
Copy link
Member

我觉得可以一并删除了 DatabaseManager,后续要做开放性的适配的时候再加回来

后面一起吧,跟上面那些错误一块。

@limingxinleo limingxinleo merged commit 1201d94 into hyperf:master Aug 7, 2019
@huangzhhui huangzhhui mentioned this pull request Aug 7, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants