This repository was archived by the owner on Feb 8, 2021. It is now read-only.
Update ipvsadm binary to a static/dynamic mix-compiled version #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laijs
reviewed
Feb 10, 2017
| cp busybox /tmp/hyperstart-rootfs/sbin/ | ||
| cp iptables /tmp/hyperstart-rootfs/sbin/ | ||
| cp ipvsadm /tmp/hyperstart-rootfs/sbin/ | ||
| cp libm.so.6 /tmp/hyperstart-rootfs/lib64/ |
Contributor
There was a problem hiding this comment.
libm is still being used by iptables
ldd build/iptables
linux-vdso.so.1 => (0x00007ffdfbbf8000)
libm.so.6 => /lib64/libm.so.6 (0x00007fe2be9a1000)
libc.so.6 => /lib64/libc.so.6 (0x00007fe2be5e0000)
/lib64/ld-linux-x86-64.so.2 (0x00007fe2becb0000)
laijs
reviewed
Feb 10, 2017
build/make-initrd.sh
Outdated
| for bin in ${LDD_BINARIES[@]} | ||
| do | ||
| ldd /tmp/hyperstart-rootfs/${bin} | while read line | ||
| do |
laijs
reviewed
Feb 10, 2017
|
|
||
| ldd /tmp/hyperstart-rootfs/init | while read line | ||
| LDD_BINARIES=(/init /sbin/ipvsadm /sbin/iptables) | ||
| for bin in ${LDD_BINARIES[@]} |
Contributor
There was a problem hiding this comment.
it is recommended to use the libs provided by the src-tree or built from the src-tree.
currently /init use the host libs, it will be also fixed later.
Contributor
Author
There was a problem hiding this comment.
I did this because I meet some inconsistent issue when using libc(libc-2.23.so) on my host. Since All of them will be carried by hyperstart, it should be fine.
Just please include pthread.so, it's needed by ipvsadm.
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Signed-off-by: Crazykev <crazykev@zju.edu.cn>
Contributor
Author
|
@laijs updated. |
Contributor
|
retest this please, hykins |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous ipvsadm binary is fully static built, while static linking of glibc has some bad effect. And libraries also used by
initandiptablesbinary like libm.so and libc.so should be shared.To solve this, I try to link libraries like libnl and popt statically, glibc like libm/libc/libpthread dynamically. See Dockerfile and build script from https://github.com/Crazykev/dev-tools/tree/master/ipvsadm-static, and ipvsadm source code from https://github.com/Crazykev/ipvsadm.
To get this binary, you can use build a image with Dockerfile and build script from here, and run
hyperctl run --rm -v [ipvsadm-dir]:/data ipvsadm-staticThis will reduce the size of hyperstart image from 5.4M to 5.1M in my environment.