This repository was archived by the owner on Feb 8, 2021. It is now read-only.
Symlink mkdir for file volume path #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laijs
reviewed
Mar 10, 2017
src/util.c
Outdated
| if (!strcmp(comp, "..")) { | ||
| if (strlen(parent) > strlen(root)) { | ||
| /* go back one level */ | ||
| char *p = strrchr(parent, '/'); |
Contributor
There was a problem hiding this comment.
use p - parrent >= strlen(root) rather than strlen(parent) > strlen(root)
When walking .., go back one level of path unless it is root. Signed-off-by: Peng Tao <bergwolf@gmail.com>
modify hyper_path directly to save one strdup, and move common part of caller code inside. Signed-off-by: Peng Tao <bergwolf@gmail.com>
bergwolf
force-pushed
the
symlink_mkdir
branch
2 times, most recently
from
efde2b4 to
7fe201c
Compare
Member
Author
|
hykins failed on network error... retest this please hykins |
For both device and fsmap based file volumes, the mountpoints need to be in chroot jail as well. Signed-off-by: Peng Tao <bergwolf@gmail.com>
Member
Author
|
hykins failed on hyperhq/hyperd#557, retest please, @hykins |
Member
Author
|
retest this please, @hykins |
1 similar comment
Member
Author
|
retest this please, @hykins |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file volume path also needs to be resolved in a chroot jail.
Also simplify hyper_mkdir_at() and hyper_mkdir_follow_link() a bit.