This repository was archived by the owner on Feb 8, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 63
Print version and git commit in hyperstart #291
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
Member
|
ok to test, hykins |
Member
|
Do we need a fancy hello screen like this, @WeiZhang555 ? |
Contributor
Author
|
Currently it will only log hyperstart version into runv log files, like: What kind of hello screen do you mean? @gnawux |
When start container, print git commit in hyperstart to show accurate version number. Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
e8af3ff to
fb8322e
Compare
Contributor
Author
|
Improve the message a little bit: |
Member
|
hykins failed because of hyperhq/hyperd#557, retest this please |
Member
|
@WeiZhang555 Generally, I agree with this patch. And @laijs @gao-feng @bergwolf , do you guys have any comments? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When start container, print git commit in hyperstart to show accurate
version number.
Signed-off-by: Zhang Wei zhangwei555@huawei.com