Skip to content
This repository was archived by the owner on Feb 8, 2021. It is now read-only.

Conversation

@WeiZhang555
Copy link
Contributor

When start container, print git commit in hyperstart to show accurate
version number.

Signed-off-by: Zhang Wei zhangwei555@huawei.com

@Jimmy-Xu
Copy link

Can one of the admins verify this patch?

@gnawux
Copy link
Member

gnawux commented Apr 11, 2017

ok to test, hykins

@gnawux
Copy link
Member

gnawux commented Apr 11, 2017

Do we need a fancy hello screen like this, @WeiZhang555 ?

@WeiZhang555
Copy link
Contributor Author

Currently it will only log hyperstart version into runv log files, like:

I0411 17:41:00.698544   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] Freeing unused kernel memory: 944K (ffffffff81896000 - ffffffff81982000)
I0411 17:41:00.698826   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] Write protecting the kernel read-only data: 8192k
I0411 17:41:00.699351   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] Freeing unused kernel memory: 1096K (ffff8800014ee000 - ffff880001600000)
I0411 17:41:00.700297   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] Freeing unused kernel memory: 528K (ffff88000177c000 - ffff880001800000)
I0411 17:41:00.700516   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] 
I0411 17:41:00.700851   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] <**********************************************************************
I0411 17:41:00.701138   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] < Hyperstart Version: version: 0.8.0, commit: 0.8.0-23-gb50af82
I0411 17:41:00.701466   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] <**********************************************************************
I0411 17:41:00.701591   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] uptime 0.19 0.01
I0411 17:41:00.701640   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] 
I0411 17:41:00.701801   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] create directory /dev/pts
I0411 17:41:00.702035   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] probe /sys/bus/pci/devices//0000:00:00.0
I0411 17:41:00.702263   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] found vendor: 1af4 ID: 1100
I0411 17:41:00.702463   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] probe /sys/bus/pci/devices//0000:00:01.3
I0411 17:41:00.702677   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] found vendor: 1af4 ID: 1100
I0411 17:41:00.702875   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] probe /sys/bus/pci/devices//0000:00:03.0
I0411 17:41:00.703080   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] found vendor: 1af4 ID: 8
I0411 17:41:00.703286   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] probe /sys/bus/pci/devices//0000:00:01.1
I0411 17:41:00.703496   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] found vendor: 1af4 ID: 1100
I0411 17:41:00.703697   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] probe /sys/bus/pci/devices//0000:00:02.0
I0411 17:41:00.703897   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] found vendor: 1af4 ID: 3
I0411 17:41:00.704093   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] probe /sys/bus/pci/devices//0000:00:01.0
I0411 17:41:00.704313   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] found vendor: 1af4 ID: 1100
I0411 17:41:00.704514   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] probe /sys/bus/pci/devices//0000:00:04.0
I0411 17:41:00.704720   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] found vendor: 1af4 ID: 9
I0411 17:41:00.704861   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] cannot find vsock device
I0411 17:41:00.705048   20764 vm_console.go:96] SB[vm-JmXfOqBmEh] [CNL] open hyper channel /dev/vport0p1

What kind of hello screen do you mean? @gnawux

When start container, print git commit in hyperstart to show accurate
version number.

Signed-off-by: Zhang Wei <zhangwei555@huawei.com>
@WeiZhang555
Copy link
Contributor Author

Improve the message a little bit:

I0411 17:47:02.492613   25707 vm_console.go:96] SB[vm-EfoJSKvQSl] [CNL] 
I0411 17:47:02.492946   25707 vm_console.go:96] SB[vm-EfoJSKvQSl] [CNL] <**********************************************************************
I0411 17:47:02.493215   25707 vm_console.go:96] SB[vm-EfoJSKvQSl] [CNL] < Hyperstart Version: 0.8.0, commit: 0.8.0-23-g99f8298
I0411 17:47:02.493551   25707 vm_console.go:96] SB[vm-EfoJSKvQSl] [CNL] <**********************************************************************

@gnawux
Copy link
Member

gnawux commented Apr 11, 2017

hykins failed because of hyperhq/hyperd#557, retest this please

@gnawux
Copy link
Member

gnawux commented Apr 11, 2017

@WeiZhang555 Generally, I agree with this patch.

And @laijs @gao-feng @bergwolf , do you guys have any comments?

@laijs laijs merged commit 295dd43 into hyperhq:master Apr 12, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants