This repository was archived by the owner on Feb 8, 2021. It is now read-only.
add maintainers rules and list #518
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
To introduce more community contributors and maintainers, we need specify these rules. Hence we borrow the rules from the containerd project. However, I am not sure should we have a "Benevolent Dictator for Life". Please comment here, guys. |
Crazykev
reviewed
Jun 19, 2017
MAINTAINERS
Outdated
| [People.laijs] | ||
| Name = "Jiangshan Lai" | ||
| Email = "jiangshanlai@gmail.com" | ||
| GitHub = "estesp" |
Contributor
There was a problem hiding this comment.
Should be typo here, "estesp"->"laijs"
The rules referenced containerd and other projects Signed-off-by: Wang Xu <gnawux@gmail.com>
Member
Author
|
update the rules, eliminate the "Benevolent Dictator for Life". I don't like to step onto this role. Instead, we employ simple reviewers and approvers. Now I need one reviewer and one approver to merge it. |
bergwolf
reviewed
Jun 22, 2017
| frivolous, say so. | ||
|
|
||
| Larger changes typically work best with design documents, similar to those found | ||
| in `design/`. These are focused on providing context to the design at the time |
Member
There was a problem hiding this comment.
well, we don't have a design/ directory...
Member
Author
There was a problem hiding this comment.
I think I added one in this commit....
jimoosciuc
pushed a commit
to jimoosciuc/runv
that referenced
this pull request
May 26, 2020
add maintainers rules and list
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rules are copied from containerd project with some minor modification:
Signed-off-by: Wang Xu gnawux@gmail.com