add a Connection Pool to the Client #363

Closed
seanmonstar opened this Issue Mar 7, 2015 · 3 comments

Projects

None yet

2 participants

@seanmonstar
Member

Some notes:

  • There should be a trait, such that others can create a specialized pool if they want
  • must keep in mind that Client supports custom NetworkConnectors
@seanmonstar seanmonstar added the client label Mar 7, 2015
@andydude
andydude commented Mar 7, 2015

I would like to help with this.

@seanmonstar
Member

cc @jamwt

@seanmonstar
Member

blocks #41

@seanmonstar seanmonstar added a commit that referenced this issue Apr 28, 2015
@seanmonstar seanmonstar feat(client): add a Connection Pool
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
1f0d3db
@seanmonstar seanmonstar added a commit that referenced this issue Apr 28, 2015
@seanmonstar seanmonstar feat(client): add a Connection Pool
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
5d6e95a
@seanmonstar seanmonstar added a commit that referenced this issue Apr 28, 2015
@seanmonstar seanmonstar feat(client): add a Connection Pool
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
e9c7133
@seanmonstar seanmonstar added a commit that referenced this issue Apr 29, 2015
@seanmonstar seanmonstar feat(client): add a Connection Pool
This adds a connection pool to the Client that is used by default. It
accepts any other NetworkConnector, and simply acts as a
NetworkConnector itself. Other Pools can exist by simply providing a
custom NetworkConnector. This Pool is only used by default if you also
use the default connector, which is `HttpConnector`. If you wish to use
the Pool with a custom connector, you'll need to create the Pool with
your custom connector, and then pass that pool to the
Client::with_connector.

This also adds a method to `NetworkStream`, `close`, which can be used
to know when the Stream should be put down, because a server requested
that the connection close instead of be kept alive.

Closes #363
Closes #41
1e72a8a
@seanmonstar seanmonstar closed this in #486 Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment