New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(header): add ContentType::xml() constructor #1329

Merged
merged 2 commits into from Sep 22, 2017

Conversation

Projects
None yet
2 participants
@spk
Contributor

spk commented Sep 20, 2017

This only add new constructor ContentType::xml()
Cheers

@@ -74,6 +74,12 @@ impl ContentType {
ContentType(mime::TEXT_HTML)
}
/// A constructor to easily create a `Content-Type: text/xml; charset=utf-8` header.

This comment has been minimized.

@seanmonstar

seanmonstar Sep 20, 2017

Member

The docs say text/xml; charset=utf-8, but TEXT_XML is text/xml. Either the documentation is wrong, or the implementation :D

I've typically stayed away from XML as much as possible (lifestyle choice), so I can't say from experience which is more common. I suspect including the charset is?

This comment has been minimized.

@spk

spk Sep 22, 2017

Contributor

Hehe; for me its more without charset; made a fix in spk@4d893a7

@spk spk force-pushed the spk:add-ContentType-xml branch from ecdc233 to 4d893a7 Sep 22, 2017

@seanmonstar seanmonstar merged commit 92595e8 into hyperium:master Sep 22, 2017

3 checks passed

commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@seanmonstar

This comment has been minimized.

Member

seanmonstar commented Sep 22, 2017

Great, thanks!

@spk spk deleted the spk:add-ContentType-xml branch Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment