New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(lib): replace Vec::set_len(0) with clear #1619

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
2 participants
@lnicola
Contributor

lnicola commented Aug 2, 2018

These were trivially safe, but it's still a good idea to avoid unsafe here, even if just for PR purposes.

@seanmonstar seanmonstar merged commit c837fb9 into hyperium:master Aug 2, 2018

3 checks passed

commit-message-check/gitcop All commit messages are valid
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@seanmonstar

This comment has been minimized.

Member

seanmonstar commented Aug 2, 2018

Ok! I noticed that issue in std was fixed that should optimize clear better. I guess it won't be available until... Rust 1.30?

@lnicola

This comment has been minimized.

Contributor

lnicola commented Aug 2, 2018

I don't really expect that additional check to matter too much in the grand scheme of things.

Indeed, it missed 1.29 by a day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment