Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(http2): allow HTTP/2 requests by ALPN when http2_only is unset #2527

Merged
merged 1 commit into from May 19, 2021

Conversation

goffrie
Copy link
Contributor

@goffrie goffrie commented Apr 29, 2021

Previously, Hyper would unconditionally reject requests with Version::HTTP_2 if http2_only(true) was not provided when building the client. This change allows such requests to succeed as long as the underlying connection is actually negotiated as HTTP/2.

@seanmonstar seanmonstar requested a review from sfackler May 13, 2021 01:56
@seanmonstar
Copy link
Member

@sfackler This looks right to me, but want to look as well, since you've done a bit with ALPN?

@seanmonstar seanmonstar merged commit be9677a into hyperium:master May 19, 2021
19 checks passed
@goffrie goffrie deleted the http2-request-alpn branch June 3, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants