Skip to content

Conversation

@pyfisch
Copy link
Contributor

@pyfisch pyfisch commented May 16, 2015

This allows more precise errors in the future and makes it easier to use
the try!() macro in some cases.

BREAKING CHANGE: Error enum extended. Return type of header/shared/
types changed.

src/error.rs Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo ivalid

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.45% when pulling 3acc852 on pyfisch:errors into c8086db on hyperium:master.

@seanmonstar
Copy link
Member

I don't get why you want to use Error::Value here, instead of Error::Header. A Value could be from just about anything, no?

@pyfisch
Copy link
Contributor Author

pyfisch commented May 19, 2015

Ok, I will suse Error::Header but I think it is a bad thing to reuse a header code. Error::Header is already used by httpparse. The relativly precise Errors from the parser are merged into a few codes, I think this is bad because you loose useful information, but this is not the topic here.

This allows more precise errors in the future and makes it easier to use
the try!() macro in some cases.

BREAKING CHANGE: Error enum extended. Return type of header/shared/
types changed.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.64% when pulling 5d66939 on pyfisch:errors into ca6cf2b on hyperium:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.64% when pulling 5d66939 on pyfisch:errors into ca6cf2b on hyperium:master.

@seanmonstar
Copy link
Member

Optionally, a specific header could have it's own error types. Such as if there are multiple specific things that can go wrong during parsing it...

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 85.64% when pulling 5d66939 on pyfisch:errors into ca6cf2b on hyperium:master.

@pyfisch
Copy link
Contributor Author

pyfisch commented May 20, 2015

Yes it could habve one. Any problems remaining?

seanmonstar added a commit that referenced this pull request May 20, 2015
feat(headers): return hyper::Error instead of () from header components
@seanmonstar seanmonstar merged commit 5747792 into hyperium:master May 20, 2015
@pyfisch pyfisch deleted the errors branch May 20, 2015 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants