Skip to content

Conversation

@nstoddard
Copy link

Compiling with default_features=false will now omit SSL support.

This introduces a ton of cfg annotations, but I don't know how to avoid them :(. It's quite ugly, but it seems to work.

BTW, I hope I got the title format correct.

Fixes #541

Compiling with default_features=false will now omit SSL support.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.64% when pulling fcda403 on nstoddard:master into 5747792 on hyperium:master.

@pyfisch
Copy link
Contributor

pyfisch commented May 23, 2015

openssl is optional for cookies: https://github.com/alexcrichton/cookie-rs/blob/595a9e095bef8d98691bd1eed135d9e540f279e0/Cargo.toml, so you should not kick out cookie support completly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* imports are evil, so do not change the normal import.

EDIT: In this special case they can stay.

@seanmonstar
Copy link
Member

I agree, let's not remove cookie entirely. We can turn just turn on or off cookie's usage of openssl.

I seem room for improvement in cookie's feature usage though: the jar could still be provided, and just have the signing methods and types conditional inside jar.rs, but oh well.

@seanmonstar
Copy link
Member

Besides those comments, this looks great! I'd been thinking of providing this at some point, but never got around to it. Thanks for the effort!

@mlalic
Copy link
Contributor

mlalic commented Jun 3, 2015

Since the HTTP/2 stuff got merged, openssl found its way back in :) I've published a new version of solicit (0.3) to crates.io, that relegates it to an optional dependency too, behind the "tls" feature. Hyper doesn't use anything from there yet anyway, so it should be fine to just go with the default set in all cases.

@seanmonstar
Copy link
Member

This was actually merged in #577.

@nstoddard
Copy link
Author

Oh, I totally forgot about this PR. Sorry about that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make OpenSSL an optional dependency

5 participants